Polish translation

Anonymous User Event Creation:

beside recaptcha 'bug' mentioned earlier there is problem in zip file

jevanonuser.xml manifest file doesn't have info about sys.ini file that is located in package, there is only this definition:

	<languages folder="languages">
		<language tag="en-GB">en-GB.plg_jevents_jevanonuser.ini</language>
   	</languages>

there are TWO folders in zip file with language files:

language\en-GB\en-GB.plg_jevents_jevanonuser.sys.ini
languages\en-GB.plg_jevents_jevanonuser.ini

corect manifest file should be:

	<languages folder="language">
		<language tag="en-GB">en-GB.plg_jevents_jevanonuser.ini</language>
		<language tag="en-GB">en-GB.plg_jevents_jevanonuser.sys.ini</language>
   	</languages>

ini and sys.ini files should be moved to \language folder.

Going back to Bronze plugins...

JEvents Meta Tags:

manifest xml file plugins\jevents\jevmetatags\jevmetatags.xml doesn't have any description string:

	<description></description>

there is defined JEV_METATAG_DESC key in sys.ini

Missing Events Finder:

hard coded string in manifest file plugins\jevents\jevmissingevent\jevmissingevent.xml:

	<description>Attempts to find suitable menu item for events that cannot display on selected menu item</description>

Event Detail in Popups:

hard coded string in manifest file plugins\jevents\jevpopupdetail\jevpopupdetail.xml:

    <description>Event detail links converted to modal box popups and also event editing menu items when popup event editing is enabled</description>

(also in ver 3.2.1)

Remote Modules Loader:

ALL strings hard coded in xml file modules\mod_remoteloader\mod_remoteloader.xml


PS. it would be MUCH easier that file names at Transiflex would be corelated with actual en-GB file names used in installation packages...

AutoCreate Authorised Users:

hard coded description and name strings in plugins\user\jevuser\jevuser.xml file:

	<name>User - Create JEvents Authorised User</name>
	<description>Automatically convert Joomla users into JEvents Authorised Users on Login</description>

"Minimum User Level" talk about user levels but combo box display users groups... should combo be filled with user access levels, or label should be 'Minimum user group'? I think the former (groups doesn't need to be inherited from Joomla default groups).

Actually this plugin needs some 'love'... ATM categories and calendars had to be comma separated strings rather than select them from combo box.
Yes/no radio buttons should be skinned as rest of administrator template.

Calendar Plus:

manifest file modules\mod_jevents_calendarplus\mod_jevents_calendarplus.xml doesnt install sys.ini file:

	<languages folder="admin">
		<language tag="en-GB">language/en-GB/en-GB.mod_jevents_calendarplus.ini</language>
	</languages>

sys.ini info is missing, sys.ini file is in installation package.

Module settings page need some radio buttons CSS styling.

What's with the "User browser language?" option? My browser is in polish, when I set this to 'yes' my calendar module show china or other asian language - actually this setting should be removed, module view use translated strings from JEvents (core) and there are plenty language files already.

Also I have a problem with popup window in this module.
some images
from the top:
1. Popup with event detail in jsn epic (free) template,
2. css info of the "div.modal",
3. popup where css value was set to margin: 280px (from negative value from picture nr 2.),
4. same popup in protostar template, it looks ok... except scrollbars

Tested this with setting "Load Joomla's Boostrap?" enabled/disabled with the same results.

It might be related to this

btw. I had tested this setting with disabled plugin JEvents - Popup Detail and Editing also and I get this result (again css value of div.modal was set to margin: 280px) - in this 'mode' popup loads page from where event detail 'click' was triggered.

Specified Calendars:

hard coded name in manifest file plugins\jevents\jevcalendar\jevcalendar.xml file and manifest doesn't install sys.ini:

	<languages folder="admin">
		<language tag="en-GB">language/en-GB/en-GB.plg_jevents_jevcalendar.ini</language>
   	</languages>	

sys.ini info is missing, sys.ini file is in installation package.

Also 'unnecessary' control is visible here - there is one additional input control, and there is a hidden field with same value

	<input name="jform[params][extras0]" id="jevcalendar" value="" type="text">
	<input name="JEVExtras[jform[params][extras0]]" id="compat_jevcalendar" value="jevc:4,jevc:5" type="hidden">

hide it by CSS or remove it...

Custom Fields:

Missing plugin description in manifest file plugins\jevents\jevcustomfields\jevcustomfields.xml

	<description></description>

JEV_CUSTOMFIELDS_PLUGIN_DESC key available in sys.ini language file, also plugin name hardcoded in xml file.


[size=150]English language are older than those in package zip file (43 strings at Transiflex, over 260 in zip)![/size]

Im gonna skip this until update at Transiflex.

Dynamic Legend Module:

hard coded module name and description in manifest modules\mod_jevents_dynamiclegend\mod_jevents_dynamiclegend.xml file

	<name>JEvents - Dynamic Legend</name>
	<description>Shows legend for JEvents as a dynamic drop down menu type layout</description>

PLG_INST_JEVENTS_JEVMODDYNAMICLEG_DESC is empty in the sys.ini file in package zip file - it's missing from en-GB at Transiflex.

also manifest file doesn't install sys.ini only ini file:

	<languages folder="language">
		<language tag="en-GB">en-GB.mod_jevents_dynamiclegend.ini</language>
	</languages>	

sys.ini file is located in package zip file.


Event Category Module:

ALL (module name, desc, settings) strings hard coded in modules\mod_jevents_categories\mod_jevents_categories.xml file.

Module settings page need some radio buttons CSS styling.


Event Notifications Plugin:

hard coded module name and empty description in manifest plugins\jevents\jevnotify\jevnotify.xml file, manifest doesn't install sys.ini file

	<description></description>
	(...)
	<languages folder="language">
		<language tag="en-GB">en-GB.plg_jevents_jevnotify.ini</language>
	</languages>

PLG_INST_JEVENTS_JEVNOTIFY_DESC key is in the sys.ini file.


Event Notifications Module:

hard coded module name in manifest modules\mod_jevents_notify\mod_jevents_notify.xml file, manifest doesn't install sys.ini file

	<languages folder="language">
		<language tag="en-GB">en-GB/en-GB.mod_jevents_notify.ini</language>
	</languages>		

unused keys:
JEV_REVEAL_SYMBOL
JEV_HIDE_SYMBOL
JEV_WILL_ACCEPT_HTML


Events Created by User:

hard coded plugin name and description in manifest modules\mod_jevents_notify\mod_jevents_notify.xml file

	<name>JEvents - Events Created by User</name>
	(...)
	<description>Displays summary (in latest events format) of events created by or attended by a user.  Place {jevu}userid{/jevu} in the content.</description>

phew... only 10% translated in Silver...

Simple Events Registration plugin:

hard coded strings in manifest file plugins\jevents\jevrsvp\jevrsvp.xml

				<field name="jevrsvpname" type="list" default="1" label='JEV_RSVP_NAME'  description='JEV_RSVP_NAME_DESC' >
					<option value="0">Name</option>
					<option value="1">Username</option>
					<option value="2">Both - Username and Name</option>
				</field>	

not used keys (in "latest" package(s)):
JEV_INVITATIONS
JEV_CONFIRM_ATTENDANCE

keys:
JEV_RSVP_NAME
JEV_RSVP_NAME_DESC
should be moved from sys.ini to ini language file


Facebook Like Button plugin:

hard coded plugin name and description in manifest plugins\jevents\jevfacebook\jevfacebook.xml file:

	<name>JEvents - Enables Facebook Like Button for Event Descriptions</name>
	(...)
	<description>Enable  Facebook Like Button for Event Descriptions</description>

sys.ini language file is 'missing' (not used, ie for above keys) and manifest file only install ini file:

	<languages folder="language">
		<language tag="en-GB">en-GB.plg_jevents_jevfacebook.ini</language>
	</languages>	

Also I don't think that strings in admin-plg_jevents_jevfacebooksysini are correct
at Transifex plugin name and description are like this:
name "JEvents - Facebook Plugin"
description "This plugin pushes JEvents events to Facebook"

but in manifest file description says "Enable Facebook Like Button for Event Descriptions"
and this is page when plugin was downloaded from:
https://www.jevents.net/download-area/s ... nt-buttons

Not used keys (not in zip file but still at Transifex):
PLG_JEVENTS_JEVFACEBOOK_CAT_IMAGE_VALUE
PLG_JEVENTS_JEVFACEBOOK_EVENT_IMAGE_VALUE
PLG_JEVENTS_JEVFACEBOOK_IMAGE
PLG_JEVENTS_JEVFACEBOOK_IMAGE_DESC
PLG_JEVENTS_JEVFACEBOOK_UNABLE_TO_SEND_EVENT

Is this plugin deprecated? if so remove it...

Hello,

The problem with the Hard coded XML strings is on first install Joomla! Does not load the xml file on install. Or at least we haven't found it to successfully yet. Therefore it is easier to hard code them in as the majority understand English and it's only on the initial install.

Many thanks
Tony

Carlos is looking into these hard coded strings and will eliminate them where possible - thank you for all your hard work on the translations!!

Hello,
The problem with the Hard coded XML strings is on first install Joomla! Does not load the xml file on install. Or at least we haven't found it to successfully yet.

But some of you did manage to do that, there is a duality in plugins manifest files, some plugins have names and descriptions hard coded some use keys.

As I pointed earlier even names and descriptions should be translatable - when I post at this forum I use english names to be understood (I hope its working ). But it's your product your choices

At least my spam is read.

You are right Yild, Joomla! fixed the loading of .sys.ini files since V3.3 by the looks of it :-)

Thank you very much for your contribution!

Facebook Social Plugin:

missing keys at Transifex:
PLG_JEVENTS_JEVFACEBOOK_WHENENABLED_LBL
PLG_JEVENTS_JEVFACEBOOK_WHENENABLED_DESC
PLG_JEVENTS_JEVFACEBOOK_WHENENABLED_JEVENTS
PLG_JEVENTS_JEVFACEBOOK_WHENENABLED_JEVLOCATIONS

File en-GB.plg_jevents_jevfacebooksocial.ini at Transifex needs to be updated by language file from one in zip file.

hard coded plugin name and description strings in manifest plugins\jevents\jevfacebooksocial\jevfacebooksocial.xml file:

	<name>JEvents - Facebook Social Plugin</name>
	(...)
	<description>JEvents Facebook Social Plugin for Event Descriptions</description>

manifest file installs only ini file:

	<languages folder="language">
		<language tag="en-GB">en-GB.plg_jevents_jevfacebooksocial.ini</language>
	</languages>		

sys.ini is available in package zip file

Featured Events Plugin:

hard coded plugin name in manifest plugins\jevents\jevfeatured\jevfeatured.xml file:

	<name>JEvents - Featured Events</name>
	(...)
	<description>JEVF_FEATURED_DESC</description>

JEVF_FEATURED_DESC key is defined twice - declaration can be found in ini and sys.ini file, and it should be only in sys.ini


Hide Event Details Plugin:

har coded name in manifest plugins\jevents\jevhiddendetail\jevhiddendetail.xml file:

	<name>JEvents - Hidden Detail</name>

incorrect key name in manifest plugins\jevents\jevhiddendetail\jevhiddendetail.xml file:

				<field 
					name="hiddentitle" 
					type="textarea" 
					filter="safehtml"
					cols="40" 
					rows="2" 
					default="" 
					label="PLG_JEVENTS_JEVHIDDENTITLE_HIDDEN_DESC_LABEL" 
					description="PLG_JEVENTS_JEVHIDDENTITLEHIDDEN_DESC_DESC"
				/>

PLG_JEVENTS_JEVHIDDENTITLEHIDDEN_DESC_DESC key should be changed to PLG_JEVENTS_JEVHIDDENTITLEHIDDEN_DESC_LABEL_DESC which is available in ini file


PLG_JEVENTS_JEVHIDDENDETAIL key defined twice - declaration can be found in ini and sys.ini file, and it should be only in sys.ini, in addition
it have same value as JEV_HIDDENDETAILS_PLUGIN_DESC key which is uded in install.php script - best solution is to keep one of them and change
plugins\jevents\jevhiddendetail\jevhiddendetail.xml
plugins\jevents\jevhiddendetail\install.php
accordingly.


not used keys (could not find them in main/bronze/silver):
PLG_JEVENTS_OFFER_ACCESS_CODE
PLG_JEVENTS_OFFER_ACCESS_CODE_DESC
JEV_HIDDEN_ACCESS_CODE
JEV_ACCESS_LINK

Also categories white list could use some attention - ATM input accept only comma separated ids, it could be changed to combo box with multiple choices for better usability.

Thank you for your latest post I have made all revisions as suggested except for the categories selection and pushed to Geraint for review.

Many thanks
Tony

Standard Image & File Uploads Files Plugin:

hard coded plugin name and missing description in manifest plugins\jevents\jevfiles\jevfiles.xml file:

	<name>JEvents - File and Image uploads for Event Descriptions</name>
	(...)
	<description></description>

description key PLG_INST_JEVENTS_JEVFILES_DESC is declared in sys.ini file


manifest file install only ini file:

	<languages folder="languages">
		<language tag="en-GB">en-GB.plg_jevents_jevfiles.ini</language>
	</languages>

sys.ini is available in package zip file


key JEV_PROBLEMS_COPYING_IMAGE="Problems copying original image" used in plugins\jevents\jevfiles\files\uploadhelper.php file:

			$this->error_goback(JText::_("JEV_problems_copying_image") . " $ftmp to $orig_file ");

should be changed to JEV_PROBLEMS_COPYING_IMAGE="Problems copying original image %s to %s" and code to:

			$this->error_goback(JText::sprintf("JEV_PROBLEMS_COPYING_IMAGE", $ftmp, $orig_file));

key JEV_MAX_UPLOAD_FLE_SIZE_DESC in ini file should be renamed to JEV_MAX_UPLOAD_FILE_SIZE_DESC as it's used in manifest file


JEV_FOLDER_DESC="Folder within images/stories for storing images and files" should be changed to:
JEV_FOLDER_DESC="Folder within images/ for images and files. If empty, images/stories folder will be used as storage location." (in example) - 'images/stories' is default location when folder option is empty


en-GB keys
JEV_UPLOAD_IMAGE_LEVEL, JEV_UPLOAD_IMAGE_LEVEL_DESC
JEV_UPLOAD_FILES_LEVEL, JEV_UPLOAD_FILES_LEVEL_DESC
strings are wrong, they say 'group level' but it should be 'user groups'


keys
JEV_SHOW_DEFAULT_IMAGE_ONLY_FOR_FIRST_IMAGE
JEV_SHOW_DEFAULT_IMAGE_ONLY_FOR_FIRST_IMAGE_DESC
should be moved from sys.ini to ini file


unused keys
JEV_FILES_DESC - there is already plugin description key in sys.ini file
JEV_INVALID_FILE_TYPE
JEV_ATTACH_IN_LISTS
JEV_TAG_SUMMARY
JEV_IMAGE_URL_ from 1 to 30
JEV_SIZED_IMAGE_ from 1 to 30
JEV_THUMBNAIL_URL_ form 1 to 30
in ini file


Multiple yes/no select fields use combo box... when they should be radio buttons.

Thank you language string changes have also been applied to the standard image and files plugin.

Disclaimer: if statement 'unused keys' is used - that mean that I have searched whole main/bronze/silver code for those keys (code from the newest versions of the zip files downloaded from jevents.net, for 3.4+ JEvents only).

Standard Image & File Uploads Files Plugin:

Missing key JEV_IMAGE_TITLE from ini files.



Events Tags Plugin (component + plugin):

At first I will post this few lines from language file specification:

Joomla! extension's must also specify a sys.ini file which is used
a. during the extension's installation, to allow localising the post-installation messages,
b. to build the administrator Components menu,
c. to localise component parameters and menu parameters
d. and in the Extension Manager->Manage.

It may help in further analysis of my spam


1. Hard coded name and description in component manifest file (administrator\components\com_jeventstags\manifest.xml):

	<name>JEvents Tags</name>
	(...)
	<description>Tags for JEvents</description>

2. Hard coded name in plugin manifest file (plugins\jevents\jevtags\jevtags.xml):

	<name>JEvents - Tags for Event Descriptions</name>

also plugin doesn't use any sys.ini

	<languages folder="languages">
		<language tag="en-GB">en-GB.plg_jevents_jevtags.ini</language>
   	</languages>

3. Description key is defined in ini file rather than in sys.ini (check above)

	<description>PLG_JEVENTS_JEVTAGS_CUSTOMFIELD_DESC</description>

4. PLG_JEVENTS_JEVTAGS_CUSTOMFIELD_DESC value is wrong... it doesn't reflect what this plugin do.

5. Key COM_JEVENTSTAGS_LINK_TO_MATCHING_EVENTS_DESC value is wrong... it says something about 'calendar' but it should be about 'tags'.

6. Everything that doesn't belong to sys.ini (administrator\language\en-GB\en-GB.com_jeventstags.sys.ini) as posted above should be move to 'normal' ini file.

7. Key JEV_TAGS_SUMMARY is missing, check at the bottom of this post

8. Hard coded string in administrator\components\com_jeventstags\views\tags\tmpl\edit.php file:

					<td valign="top" align="right">
						<?php echo JText::_( 'Published' ); ?>:
					</td>

should be changed to JEV_PUBLISHED.

9. Hard coded string in administrator\components\com_jeventstags\controllers\tags.php file

	$published 		= JHTML::_('select.booleanlist',  'published', 'class="inputbox"', $tag->published );

should be changed to JEV_PUBLISHED.

10. Key JEV_CLICK_TO_EDIT - i don't think that this is necesary at all in tags list -
administrator\components\com_jeventstags\views\tags\tmpl\overview.php file:

          	<td >
          		<a href="#edit" onclick="return listItemTask('cb<?php echo $i;?>','tags.edit')" title="<?php echo JText::_('JEV_CLICK_TO_EDIT'); ?>">
          		<?php echo $tag->title; ?>
          		</a>
          	</td> 

if it's link you click it either way. It looks kinda strange ATM...

11. Unused keys
COM_JEVENTSTAGS_TAGS_VIEW_DEFAULT_TITLE (declared in ini and sys.ini)
JEV_TAGS_LIST
PLG_JEVENTS_JEVTAGS_FILTERS_MOVE_ERROR
PLG_JEVENTS_JEVTAGS_FILTERS_NOT_FOUND
JEV_CUSTOMFIELD

12. key COM_JEVENTS_TAGS in administrator\language\en-GB\en-GB.com_jeventstags.menu.ini file not used anywhere - whole file can be removed imo.

13. unused key OM_JEVENTSTAGS_LOCATION_DETAIL_TEXT in en-GB.com_jeventstags.sys.ini file.

14. In addition there is HUGE commented form definition with language keys inside tags.xml file... what to do with that, is it something you will introduce in the feature or was this abbandoned?

15. hard coded string in plugins\jevents\jevtags\jevtags.php file:

 		$input = '<input type="text" placeholder="Search for matching tag" size="20" style="margin-bottom:10px;" id="taglistfilter" onkeyup="filterTagChoices()" />';

16. There might be further posts regarding "Events Tags".

------------

Tag editor problems:

When I tried to add tag with already used title (for testing purpose) I get WARNNAMETRYAGAIN popup message (javascript), after accepting this message the result is message like i.stack.imgur.com/8GdzQ.png">this but it should bring tag editor again. ATM JS is used for this, but it should use standard Joomla warning/error message (the one with a green background).

Also regarding to above problem, there is a hard coded string in administrator\components\com_jeventstags\tables\tag.php file:

		if (trim($this->title) == '') {
			$this->setError(JText::_('Your Tag must contain a title.'));
			return false;
		} 

(there is JEV_E_WARNTITLE key already in ini file that can be used for this message) and again after accepting this message we get 'document expired' info.

Both errors originate from check() function in administrator\components\com_jeventstags\tables\tag.php file.

Tags list in backend problem:

1. Publish/unpublish buttons show 'Not Authorised must be an administrator' message even if I'm superadmin (tested with authorized users (all permissions enabled), and with Joomla permissions) - changing state in tags edit window works ok.

2. Checkbox that is in tags list header doesn't work at all, checking unchecking it doesn't mark any tags.

------------

There is one thing I had noticed just now... some forms are 'preterite' than other... example:

pretty one

				<field 
					name="onlyown" 
					type="radio"
					class="btn-group"
					default="0" 
					label="PLG_JEVENTS_JEVAGENDAMINUTES_AUTHOR_ARTICLES_LABEL" 
					description="PLG_JEVENTS_JEVAGENDAMINUTES_AUTHOR_ARTICLES_DESC" >
					<option value="0">JEV_NO</option>
					<option value="1">JEV_YES</option>
				</field>

this display red/gree/white 'buttons',

not so pretty

			<field name='checkevents' type='jevboolean' default="1" label="COM_JEVENTSTAGS_CHECK_BEFORE_LINKING_LABEL" description="COM_JEVENTSTAGS_CHECK_BEFORE_LINKING_DESC" />

and this one only yes/no radio buttons.

Events Tags Plugin (component + plugin):

17. Unnecessary graphic element in edit window
string hard coded in administrator\components\com_jeventstags\views\tags\view.html.php file:

		JSubMenuHelper::addEntry(JText::_('Control Panel'), 'index.php?option='.JEVEX_COM_COMPONENT, true); 

I don't think that this was intended result

btw search your code in this plugin for "JEVEX_COM_COMPONENT" string, i.e.:

$lang 		= JFactory::getLanguage();		
$lang->load(JEVEX_COM_COMPONENT, JPATH_ADMINISTRATOR); 

18. regarding #1 from previous post, graphic explanation of this situation

19. There can be further posts regarding "Events Tags".

Events Tags Plugin (component + plugin):

20. Hard coded string in plugins\jevents\jevtags\jevtags.php file:

			$data->label = "JEV_SPECIFIED_TAGS";
			$data->description = "SPECIFY TAGS"; 

should be changed to

			$data->label = "JEV_SPECIFIED_TAGS";
			$data->description = "JEV_SPECIFY_TAGS"; 

key JEV_SPECIFY_TAGS is already declared in language file.

That's all I could find in Tags Plugin.


Any ETA when we can expect updates on Transifex?

Carlos (aka carcam), our translations co-ordinator, is about to have a baby so there may be a slight delay before these changes are processed.

Thanks for all your hard work.

Congratulations!

No hurry... I have plenty more to translate