Saturday, 16 May 2009
  81 Replies
  21.7K Visits
0
Votes
Undo
Full Polish translation with installer ver. 1.0.
Full admin & site translation.
Live demo: [url]gpu.bydgoszcz.pl[/url]

------------------- Readme // Polska instrukcja -------------------
Pe?ne spolszczenie, instalacja wraz z instalerem.

Wystarczy pobra? paczk? zip i poprzez instalator zainstalowa? pakiet.

Ewentualne b??dy i poprawki prosz? zg?asza? na <!-- e --><a href="mailto:yahoo1985@o2.pl]yahoo1985@o2.pl[/url]<!-- e -->. Spolszczenie by?o robione "na sucho" dlatego te? mog? pojawi? si? b??dy w t?umaczeniu oraz b??dy stylistyczne. Poprawki prosz? zg?asza? na email lub PW.

T?umaczenie w wersji 1.0.
Ca?o?? z powodzeniem pracuje na serwisie [url]gpu.bydgoszcz.pl[/url], joomla 1.5.10.

------------------- Download // Pobierz -------------------
http://jasinski.cal.pl/downloads/jevents-pl-PL.zip


http://jasinski.cal.pl/downloads/jevents-pl-PL.zip">>>DO POBRANIA TUTAJ<<

------------------- Pozdrawiam i ?ycz? mi?ego u?ytkowania -------------------
8 years ago
·
#6558
0
Votes
Undo
JEvents Main

1. Hard coded strings in administrator\components\com_jevents\libraries\jevbuttons.php AND administrator\components\com_jevents\libraries\jevtoolbarbuttons.php:

$message = JText::sprintf( 'Please make a selection from the list to', $todo );
(...)
$message = JText::sprintf( 'Please make a selection from the list to %s', $todo );

(both strings in each file).

Custom Fields Plugin (Version: 3.5.0 RC7)

1. Hard coded or missing strings in manifest plugins\jevents\jevcustomfields\jevcustomfields.xml file:

<name>JEvents - Custom Fields</name>
(...)
<description></description>

could use JEV_CUSTOMFIELDS_PLUGIN and JEV_CUSTOMFIELDS_PLUGIN_DESC keys.

2. Hard coded string in plugins\jevents\jevcustomfields\jevcustomfields.php file:

Jerror::raiseWarning ( null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning ( null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'JEvents has been disabled, please enable it first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents' . $rel );


3. Hard coded string in plugins\jevents\jevcustomfields\customfields\jevcfdblist.php file:

CustomFieldsHelper::textField($id, $field, JText::_("JEVCF_DBLIST_LABEL_FIELD"), JText::_('JEVCF_DBLIST_LABEL_FIELD_DESC'), "labelfield", "labelfield","User Name");

(last param).

4. Hard coded strings in plugins\jevents\jevcustomfields\views\jevcustomfields\tmpl\edit.php file:

alert("<?php echo JText::_("JEVCF_FORM_LARGER_THAN_MAXIMUM_SIZE_CHECK_HTACCESS_SETTINGS", true) ?>\n" + (inputvars.length + selectvars.length + textareavars.length) + " vs " + <?php echo $max_input_vars; ?>;);
(...)
alert("<?php echo JText::_("JEVCF_FORM_GETTING_CLOSE_TO_MAXIMUM_SIZE_CHECK_HTACCESS_SETTINGS", true) ?>\n" + (inputvars.length + selectvars.length + textareavars.length) + " vs " + <?php echo $max_input_vars; ?>;);

JEVCF_FORM_LARGER_THAN_MAXIMUM_SIZE_CHECK_HTACCESS_SETTINGS and JEVCF_FORM_GETTING_CLOSE_TO_MAXIMUM_SIZE_CHECK_HTACCESS_SETTINGS key values should use params.

5. Hard coded string in clientspecific\jevcfwurl.php file:

return "Please save the event to generate the link";

(clientspecific folder - look at point 10)

6. JEVCF_ENABLE_BUTTONS_DESC key value need some adjustment - its a multi select list, no need for info about 'comma separated values'.

7. JEV_EDIT_CUSTOM_FIELDS key value should be 'split' into two strings for new file and edit, ie, if custom file name is empty show 'new' else 'edit' (atm for new files we see 'Edit Custom Fields File : '.

8. Missing keys:
JEVCF_SEARCHABLE_DESC
(missing from language file in zip file).

9. Unused keys:
JEV_EXTRA_FIELDS
JEV_EXTRA_FIELDS_TEMPLATE
JEV_MANAGE_CUSTOM_FIELDS
JEV_CUSTOM_FIELDS_DEFAULT_DESCRIPTION
JEV_NOT_A_VALID_PLUGIN

10. Missing(?) 'clientspecific' folder in 'files' branch in manifest file:

<files>
<filename plugin="jevcustomfields">jevcustomfields.php</filename>
<filename>filters/Customfield.php</filename>
<folder>customfields</folder>
<folder>views</folder>
</files>

(don't know if any code in this folder is used...).

11. Create new field button should be disabled until we create fields group.

12. Radio type field, there is duplicated code in loadScript() function showing options twice:

CustomFieldsHelper::filterOptions($id, $field);
CustomFieldsHelper::filtermenuOptions($id, $field);


13. While creating new filed, all tooltips doesn't get bootstrap styling, in screenshot below you can see that bottom tooltip (field already in file) is in data-original-title attrib, the top image (newly created field) shows that this attribute isn't added and title attribute is used for tips
http://i.imgur.com/d2psLZt.png

14. Notes type field - creator valid ids - this field should be multi select list of users or 'authorised users' (if enabled in JEvents).

// Would be too many entries on many sites.
//CustomFieldsHelper::userids($id, $field,JText::_("JEVCF_CREATOR_NOTES_VALID_IDS"), JText::_("JEVCF_CREATOR_NOTES_VALID_IDS_DESC"));
CustomFieldsHelper::textField($id, $field, JText::_("JEVCF_CREATOR_NOTES_VALID_IDS"), JText::_('JEVCF_CREATOR_NOTES_VALID_IDS_DESC'), "userid", "userid");

Founded this code later after i wrote this above... make it a plugin option: 'list all' vs 'type ids by hand', default by hand?

15. Delete field button should show confirmation message.



[size=150]The End[/size] (Silver)
until I get reply to questions from previous post and/or Transifex update.
8 years ago
·
#6557
0
Votes
Undo
Now I need some info, below is a list of Transifex resources with 0% translation (pl), where do I download code that use some of those?
I did brief research via search window on jevents.net but with no luck for most of those resources, also searched the old downloads section...

Not counting Custom Fields package that I need to translate (which at Transifex is missing ~200 keys) my work is done... until updates at Transifex are made.


adminen-gbmod_modulecacherini
adminen-gbmod_modulecachersysini Module that allows you to cache and configure other Joomla module by user group
adminen-gbplg_system_modulecacherini
admin-pkg_modulecachersysini Advanced Page and Module Cacher for Joomla!

adminen-gbplg_jevents_jevapprovalini
adminen-gbplg_jevents_jevapprovalsysini JEvents - Approval

admin-files_jeventsmaplayoutsysini Map layout for Jevents - requires managed locations addon to work

admin - JEvents Tags - Menu - unused (yild)

admin-mod_jevents_categoriesini

admin-mod_jevents_createini

admin-plg_app_user_jeventsini This application is responsible for interaction between EasySocial and JEvents.

admin-plg_content_gwecurrencyconverterpluginini content - gwe_currency_converter Currency Converter Plugin
admin-plg_content_gwecurrencyconverterpluginsysini

admin-plg_jevents_jevcatcalini Restricts users to viewing events from categories and calendars they are authorised to view. Users who are not 'authorised' users can see no events at all.
admin-plg_jevents_jevcatcalsysini

admin-plg_jevents_jeveventsperdayini

admin-plg_jevents_jevgroupeventini
admin-plg_jevents_jevgroupeventsysini JEvents - Group Events Plugin - Version

admin-plg_jevents_jevsendfbini
admin-plg_jevents_jevsendfbsysini JEvents - Send to Facebook Plugin - Version

admin-plg_jevents_jevudjacommentsini Udja Comments

admin-plg_jevents_jevvalidgroupsini JEvents - Valid creator events
admin-plg_jevents_jevvalidgroupssysini

admin-plg_jevjcommentsini Unused (yild)

admin-plg_jnewsletter_jnewsjeventsini Unused (?)

admin-plg_rsvppro_hikashopini HikaShop Payment Gateway for JEvents RSVP Pro
admin-plg_rsvppro_hikashopsysini

admin-plg_search_jevlocsearchini JEvents Location Search plugin allow searchings JEvent Locations.
https://www.jevents.net/download-area/o ... ons-addon#

admin-plg_user_jeventsprofileini
admin-plg_user_jeventsprofilesysini JEvents Profile Fields
8 years ago
·
#6556
0
Votes
Undo
JComments Plugin

1. Hard coded strings in manifest plugins\community\jevents\jevents.xml file:

<name>JEvents - JComments</name>
(...)
<description>JEvents - Enables JComments for Event and Location Descriptions</description>


2. Hard coded strings in plugins\community\jevents\install.php file:

Jerror::raiseWarning ( null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning ( null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'JEvents has been disabled, please enable it first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents' . $rel );


4. Resource at Transifex 'admin-plg_jevjcommentsini' have 2 keys that are defined in admin-plg_jevents_jevjcommentsini which is used by JComments plugin - the resource admin-plg_jevjcommentsini should be removed.


Paid Subs Plugin

1. Hard coded strings in manifest plugins\jevents\jevpaidsubs\jevpaidsubs.xml file:

<name>JEvents - Paid Event Submission</name>
(...)
<description>Allow Event Submission by paying users</description>
(...)
<field name="prioritylevel" type="list" default="0" label="JEV_PAID_SUBS_PIORITY"
description="JEV_PAID_SUBS_PIORITY_DESC">
<option value="0">Disabled</option>
[...]
</field>



2. Manifest file installs only ini file:

<languages folder="language">
<language tag="en-GB">en-GB.plg_jevents_jevpaidsubs.ini</language>
</languages>

sys.ini file is in zip file.

3. Hard coded strings in plugins\jevents\jevpaidsubs\install.php file:

Jerror::raiseWarning(null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning(null, 'Virtuemart must be installed to use this plugin.');
(...)
Jerror::raiseWarning(null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.');
(...)
Jerror::raiseWarning(null, 'A minimum of Virtuemart V3.x is required for this addon. <br/>Please update Virtumart first.');
(...)
Jerror::raiseWarning(null, 'JEvents has been disabled, please enable it first.');
(...)
Jerror::raiseWarning(null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents');


4. JEV_SPECIAL_CATEGORIES_DESC="Purchase of these credits also opens access to creating events in these categories. Comma separated list of category ids." - there is no need for "Comma separated list of category ids." anymore - it's a multi select combobox control.

5. Misc in plugins\jevents\jevpaidsubs\fields\jevsetup.php file:

// the no shipping category name
private $catname = 'Event Tokens';
private $catdesc = 'Tokens to purchase that allow user to create events';
// the product type name
private $productname = 'Event Creation';
private $product_s_desc = 'Event Token - To allow event creation.';
private $product_desc = '<p>This product type controls the number of events that can be submitted or the time window in which events can be submitted.</p>';

look at the second issue.

6. Unused keys:
JEV_PARAMETER_NAME
JEV_PARAMETER_NAME_DESC


Paid Subs Module

1. Hard coded strings in manifest modules\mod_jevents_paidsubs\mod_jevents_paidsubs.xml file:

<name>JEvents - Paid Event Submissions</name>
(...)
<description>JEvents Paid Event Submissions Module.</description>


2. Unused keys:
JEV_PAID_EVENT_SUBMISSIONS
8 years ago
·
#6555
0
Votes
Undo
CB Integration Plugin


As this is an cbinstall package I post only what I did found while browsing files.

1. Hard coded strings in manifest jevents.xml file:

<name>CB JEvents</name>
(...)
<description>
This plugin displays a short list of events created by a user and a link to a full calendar of their events.
Down the line it may show events the user is attending or sessions being hosted too.
</description>
(...)
<tab name="JEVENTS_TAB" description="A summary of events created by this user" class="getLatestEvents" fields="0" position="cb_tabmain" displaytype="tab">
<params>
<param name="tabMessage" type="text" label="JEvents Tab Text" default="Upcoming Events created by this user" description="xxx" />
</params>
<fields>
</fields>
</tab>



2. Key UPCOMING_EVENTS_CREATED_BY_THIS_USER_OR_THEY_AREATTENDING in declared in language file as UPCOMING_EVENTS_CREATED_BY_THIS_USER_OR_THEY_ARE ATTENDING (without last '_').

3. Less is more:
JEV_REQUIRES_JEVENTS_COMPONENT should be
JEV_REQUIRES_JEVENTS_COMPONENT="<h3>JEvents Community Builder Plugin require the JEvents Component</h3>"
this is a die() function result...

4. Unused keys:
VIEW_ALL_EVENTS_HERE
SELECT_ITEM



Most of social integration plugins doesn't check if integrated plugin/extension is installed, found it only in JomSocial plugins.
8 years ago
·
#6554
0
Votes
Undo
Community Builder Creator Plugin

1. Hard coded strings in manifest plugins\jevents\jevcb\jevcb.xml file:

<name>JEvents - Community Builder Avatars/Links</name>
(...)
<description>Switch creator link to CB profile link</description>
(...)
<field name="target_itemid" type="jevmenu" default="" label="Target Menu Item" description="Menu item for target page" />
<field name="username" type="list" default="name" label="Name or Username in Link?" description="Show creator name or user name in the link" >
<option value="name">Name</option>
<option value="username">Username</option>
</field>



JomSocial Integration Plugin

1. Hard coded strings in manifest plugins\community\jevents\jevents.xml file:
a)

<name>JEvents - JomSocial Integration</name>

JEV_JOMSOCIAL_PLUGIN key can be used here.
b)

<field name="cache" type="list" default="1" label='JEV_JOMS_CACHE' description='JEV_JOMS_CACHE_DESC' >
<option value="1">Use Global</option>
<option value="0">JNo</option>
</field>
(...)
<field name="position" type="list" default="content" label="Avalaible Positions" description="Select one or more available positions from the list. You can use Ctrl-click to select more than one item.">
<option value="content">Content</option>
<option value="sidebar-top">Sidebar Top</option>
<option value="sidebar-bottom">Sidebar Bottom</option>
</field>
(...)
<field name="layout" type="text" default="" label='OVERRIDE_LAYOUT' description="Specify Template Override Layout Name e.g. detail2 or calendar2"/>
(...)
<field name="modlatest_DispLinks" type="radio" class="btn-group" default="1" label='DISPLAY_EVENTS_AS_LINKS' description="display event titles as links to the view_detail com_jevents task which will display details of the event">
<option value="0">JNo</option>
<option value="1">JYES</option>
</field>


(also JNo, JYes should be replaced by JEV_NO and JEV_YES - and then JNo, JYes could be dropped from language file)

2. Manifest file installs only ini file:

<languages folder="language/en-GB">
<language tag="en-GB">en-GB.plg_community_jevents.ini</language>
</languages>

but zip file also have sys.ini.

3. Manifest file issues:
a)
key names in language file that should be renamed - plugin options tab names are incorrect atm:
COM_PLUGINS_JEV_SYNC_TO_JEVENTS_FIELDSET_LABEL to JGLOBAL_FIELDSET_JEV_SYNC_TO_JEVENTS
COM_PLUGINS_JEV_USER_EVENTS_TAB_FIELDSET_LABEL to JGLOBAL_FIELDSET_JEV_USER_EVENTS_TAB
COM_PLUGINS_ADVANCED_SETTINGS_FIELDSET_LABEL to JGLOBAL_FIELDSET_ADVANCED_SETTINGS
b)
ADVANCED_SETTINGS key value is overwritten by value from ADVANCED_SETTINGS key declared in JEvents Main language files.
c)
missing key THE_FOLLOWING_SETTINGS_ARE_FOR_ADVANCED_USERS_ONLY
d)
key used as default field value:
UPCOMING_EVENTS_CREATED_BY_THIS_USER should be changed to string - it would seem that language keys cannot be used as field 'default' value, after this change remove unused key.

4. Hard coded string in plugins\community\jevents\install.php file:

Jerror::raiseWarning ( null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning ( null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'A JomSocial is required to be installed for this addon. <br/>Please Install JomSocial first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'JEvents has been disabled, please enable it first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents' . $rel );


5. Duplicate key values in ini and sys.ini:
JEV_JOMSOCIAL_DESC and JEV_JOMSOCIAL_PLUGIN_DESC - only one plugin description key is needed.

6. Unused keys:
PLG_JEVENTS_TITLE
JEV_PARAMS
JEVENTS_TAB_TEXT_DEFAULT_2
EVENT_LOCATION


JomSocial Stream Integration Plugin

1. Hard coded strings in manifest plugins\jevents\jevjsstream\jevjsstream.xml file:

<name>JEvents - JomSocial Stream</name>
(...)
<description>Record event saving and updating in the JomSocial Activity Stream</description>
(...)
<field name="target_itemid" type="jevmenu" class="btn-group" default="" label='TARGET_MENU_ITEM' description="Menu item for target page - leave blank for all menu items" />


2. Manifest file installs only ini file:

<languages folder="language">
<language tag="en-GB">en-GB.plg_jevents_jevjsstream.ini</language>
</languages>

but zip file also have sys.ini.

3. Hard coded strings in plugins\jevents\jevjsstream\install.php file:

Jerror::raiseWarning(null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel);
(...)
Jerror::raiseWarning(null, 'JEvents has been disabled, please enable it first.' . $rel);
(...)
Jerror::raiseWarning(null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents' . $rel);


4. Hard coded strings in plugins\jevents\jevjsstream\jomsocial\jomsocial_rule.xml file:

<name>Create an Event</name>
<description>Give points when registered user creates an event</description>
(...)
<name>Delete an Event</name>
<description>Removed points from event creator when an event is deleted</description>

(don't know if its used or not...)

5. Error in language file administrator\language\en-GB\en-GB.plg_jevents_jevjsstream.ini format at line 10.

6. Missing keys:
JEV_CREATOR_LINK

7. Unused keys:
JEV_EVENT_OPTIONS
JEV_ICAL_EXPORT
JEV_ADMIN_PANEL
8 years ago
·
#6553
0
Votes
Undo
CCK Linkage Plugin

1. Hard coded string in manifest manifest plugins\jevents\jevcck\jevcck.xml file:
a)

<name>JEvents - CCK Listing</name>

key JEV_CCK_PLUGIN can be used here.
b)

<field name="ccktype" type="list" default="" label="JEV_SELECT_CCK" description="JEV_SELECT_CCK_TIP" >
<option value="content">Joomla Content</option>
<option value="easyblog">EasyBlog</option>
<!--
<option value="sobi2">Sobi2</option>
//-->
<option value="sobipro">SobiPro</option>
<option value="k2">K2</option>
<option value="zoo">Zoo</option>
</field>
<field name="cckpopup" type="radio" class="btn-group" default="1" label="JEV_DETAIL_POPUP" description="JEV_DETAIL_POPUP_TIP" >
<option value="0">No</option>
<option value="1">Yes</option>
</field>

regarding ccktype options, at least 'joomla contents' should be translatable.

2. Hard coded string in plugins\jevents\jevcck\cck\k2view.php file:

$mitems [] = JHTML::_('select.option', '0', '- ' . JText::_('Select Category') . ' -');

should be 'SELECT_CATEGORY';

3. Hard coded string in plugins\jevents\jevcck\cck\zooview.php file:

$mitems [] = JHTML::_('select.option', '0', '- ' . JText::_('Select Category') . ' -');
(...)
$categories[] = JHTML::_('select.option', '0', '- ' . JText::_('Select Application') . ' -');

should be 'SELECT_CATEGORY' for the first one, there is no key for 'select aplication'.

4. Hard coded strings in plugins\jevents\jevcck\cck\contentview.php file:
(columns headers, 2nd param)

<?php echo JHTML::_('grid.sort', 'Title', 'c.title', @$lists['order_Dir'], @$lists['order']); ?>
(...)
<?php echo JHTML::_('grid.sort', 'Access', 'groupname', @$lists['order_Dir'], @$lists['order']); ?>
(...)
<?php echo JHTML::_('grid.sort', 'ID', 'c.id', @$lists['order_Dir'], @$lists['order']); ?>
(...)
<?php echo JHTML::_('grid.sort', 'Section', 'section_name', @$lists['order_Dir'], @$lists['order']); ?>
(...)
<?php echo JHTML::_('grid.sort', 'Category', 'cc.title', @$lists['order_Dir'], @$lists['order']); ?>
(...)
<?php echo JHTML::_('grid.sort', 'Date', 'c.created', @$lists['order_Dir'], @$lists['order']); ?>

(j1.6 tests for 'Section' can be dropped from code - it's ancient history ;) )

5. Hard codes trings in plugins\jevents\jevcck\install.php file:

Jerror::raiseWarning ( null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning ( null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'JEvents has been disabled, please enable it first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents' . $rel );


6. Manifest file installs only ini file:

<languages folder="language">
<language tag="en-GB">en-GB/en-GB.plg_jevents_jevcck.ini</language>
</languages>

but zip file also have sys.ini.

7. Duplicate keys in administrator\language\en-GB\en-GB.plg_jevents_jevcck.ini AND administrator\language\en-GB\en-GB.plg_jevents_jevcck.sys.ini files:
JEV_SELECT_CCK
JEV_SELECT_CCK_TIP
JEV_CCK_SUMMARY
JEV_SELECT_LISTING
JEV_SELECT
JEV_POPUP_WIDTH
JEV_POPUP_HEIGHT
JEV_SEARCH_BY_LISTING
JEV_DETAIL_POPUP
JEV_DETAIL_POPUP_TIP
JEV_LISTING_SUMMARY
JEV_LISTING_ADDON
JEV_ALREADY_SELECTED
JEV_REMOVE_CCKLISTING_WARNING
JEV_REMOVE_CCK_LISTING
JEV_SPECIFY_LISTINGS
JEV_SPECIFY_LISTINGS_TIP
JEV_MAX_LISTINGS
JEV_TARGET_MENU_ITEM
SELECT_CATEGORY
GO
RESET
FILTER
NUM
ID
JEV_REDIRECT_LABEL
JEV_REDIRECT_DESC
(should stay only in one file),
JEV_YES
JEV_NO
(redundand with JEvents core).

8. Popup window when we can select lists isn't loading 'any' language file, strings like this <?php echo JText::_('Go'); ?> are used as they are as strings, not keys.

9. Wrong field type in manifest file:

<field name="inlists" type="jevboolean" class="btn-group" default="0" label="JEV_AVAILABLE_IN_LISTS" description="JEV_AVAILABLE_IN_LISTS_DESC" />

this probably should be type="radio" - atm this display edit control rather than yes/no radio.

10. I don't know much about CCKs like K2, sobi, etc, so I tested this on Joomla Content... hmm... and Im confused. If we are talking about lists (of some content), why there are articles to choose from rather than articles categories? If I add article from this list to an event it just display 404 error.


K2embedded Plugin

1. Hard coded string in file:

<name>K2 JEvents Plugin</name>
(...)
<description>This plugin lists latest events related to the K2 item</description>
(...)
<field name="showpasteventreset" type="radio" class="btn-group" default="0" label="Show Past Event Reset Checkbox" description="">
<option value="0">JEV_NO</option>
<option value="1">JEV_Yes</option>
</field>


2. Usused keys in administrator\language\en-GB\en-GB.plg_k2_k2embedded.ini file:
JEV_SELECT_CCK_TIP
JEV_CCK_SUMMARY
JEV_SELECT_LISTING
JEV_SELECT
JEV_POPUP_WIDTH
JEV_POPUP_HEIGHT
JEV_SEARCH_BY_LISTING
JEV_DETAIL_POPUP
JEV_DETAIL_POPUP_TIP
JEV_LISTING_SUMMARY
JEV_LISTING_ADDON
JEV_ALREADY_SELECTED
JEV_REMOVE_CCKLISTING_WARNING
JEV_REMOVE_CCK_LISTING
JEV_SPECIFY_LISTINGS
JEV_SPECIFY_LISTINGS_TIP
JEV_MAX_LISTINGS
JEV_TARGET_MENU_ITEM
SELECT_CATEGORY
GO
RESET
FILTER
NUM
ID
JEV_REDIRECT_LABEL
JEV_REDIRECT_DESC
(all keys are from CCK plugin),
JEV_YES
JEV_NO
(redundand with JEvents core).
8 years ago
·
#6552
0
Votes
Undo
AcyMailing Integration Plugin

1. Hard coded strings in manifest plugins\acymailing\tagjevents_jevents\tagjevents_jevents.xml file:

<name>JEvents - AcyMailing Tag</name>
(...)
<description>This plugin enables you to add a latest events summary in your Newsletter</description>


2. Could not find any key from en-GB.plg_acymailing_tagjevents_jevents.ini file in Transifex resources - resource at Transifex for this file is missing.

JNews Integration Plugin

1. Hard coded strings in manifest plugins\jnews\jnewsjevents\jnewsjevents.xml file:

<name>JNewsletter Tags : Latest JEvents</name>
(...)
<description>This plugin enables you to add a latest events summary in your Newsletter</description>

There are JEV_JNEWS_PLUGIN and JEV_JNEWS_PLUGIN_DESC keys in sys.ini file that can be used.

2. Manifest file correction:

<files>
<filename plugin="jnewsjevents">jnewsjevents.php</filename>
<folder>languages</folder>
</files>
<languages folder="languages">
<language tag="en-GB">en-GB.plg_jnews_jnewsjevents.ini</language>
</languages>

should be:

<files>
<folder>language</folder>
<filename plugin="jnewsjevents">jnewsjevents.php</filename>
</files>
<languages folder="language">
<language tag="en-GB">en-GB/en-GB.plg_jnews_jnewsjevents.ini</language>
<language tag="en-GB">en-GB/en-GB.plg_jnews_jnewsjevents.sys.ini</language>
</languages>

the folders structure in zip file needs some adjustments, also there is no need for third language file languages\en-GB.plg_jnewsletter_jnewsjevents.ini in zip package - its redundand, not used and should be removed, all language files should be moved to en-GB subfolder.

3. This plugin doesn't test if JEvents is installed - whole code in preflight() function is commented (and inside this block are hard coded strings that should be translatable (?)).


J!MailAlerts Integration Plugin

1. Hard coded strings in manifest plugins\emailalerts\jev_latestevents\jev_latestevents.xml file:

<name>J!MailAlerts - Latest Events</name>
(...)
<description>
This plugin fetches latest events.
FOLLOW these steps to SET Plugin Parameters=>
1.Set Enabled = Yes, click on apply. 2.configure Events display settings
</description>

"FOLLOW these steps to SET Plugin Parameters=> 1.Set Enabled = Yes, click on apply. 2.configure Events display setting" - this is unnecessary, instead make description more releated to it's function.

2. Wrong language file name in manifest plugins\emailalerts\jev_latestevents\jev_latestevents.xml file:

<languages folder="admin">
<language tag="en-GB">language/en-GB/en-GB.plg_emailalerts_jev_latestnews.ini</language>
</languages>

there is no file in zip file with that name, should be:

<languages folder="admin">
<language tag="en-GB">language/en-GB/en-GB.plg_emailalerts_jev_latestevents.ini</language>
</languages>

as this file exists in zip file and at Transiflex.



I have tested multiple manifest structures to incorporate using keys in preflight/postflight functions in installation process and this is what I found is 'best':

install.xml for (only) admin language files:

<files>
<folder>language</folder>
<filename plugin="jnewsjevents">jnewsjevents.php</filename>
</files>
<languages folder="language">
<language tag="en-GB">en-GB/en-GB.plg_jnews_jnewsjevents.ini</language>
<language tag="en-GB">en-GB/en-GB.plg_jnews_jnewsjevents.sys.ini</language>
</languages>

folder structure:

language/
en-GB/
en-GB.plg_jnews_jnewsjevents.ini
en-GB.plg_jnews_jnewsjevents.sys.ini


for site and admin language files:

<files>
<filename plugin="agendaminutes">agendaminutes.php</filename>
<folder>language</folder>
<folder>agendaminutes</folder>
</files>
<languages folder="admin">
<language tag="en-GB">language/en-GB/en-GB.plg_jevents_agendaminutes.ini</language>
<language tag="en-GB">language/en-GB/en-GB.plg_jevents_agendaminutes.sys.ini</language>
</languages>

folder structure:

admin/
language/
en-GB/
en-GB.plg_jevents_agendaminutes.ini
en-GB.plg_jevents_agendaminutes.sys.ini
language/
en-GB/
en-GB.plg_jevents_agendaminutes.ini
8 years ago
·
#6551
0
Votes
Undo
yes... yes...

ok... going back to translations :P

REGARDING MY PREVIOUS POSTS: FILES BELOW NEEDS TO BE CHECKED FOR HARD CODED STRINGS THAT I MAY NOT POSTED EARLIER:
plugins\jevents\jevtimelimit\install\scriptfile.php
administrator\manifests\packages\jevpeople\installpkg.php
plugins\jevents\jevanonuser\install.php
plugins\jevents\jevusers\install.php
administrator\manifests\packages\jeventstags\install.php
plugins\jevents\jevfiles\install.php
plugins\jevents\jevhiddendetail\install.php
modules\mod_jevents_dynamiclegend\install.php
plugins\jevents\jevcustomfields\install.php
plugins\jevents\jevcalendar\install.php
plugins\jevents\jevcalendar\install.php
plugins\system\autotweetjevents\install.php
plugins\content\jevent_embed\install.php

All file names like this needs to be checked:
install.php
scriptfile.php
installpkg.php


Timelimit Plugin

1. Hard coded name and description in manifest plugins\jevents\jevtimelimit\jevtimelimit.xml file:

<name>JEvents - Time Limits</name>
(...)
<description>Limits events displayed to a range of dates. For example auto archiving expired events or blocking events more than a set time in the future.</description>


2. Hard coded strings in plugins\jevents\jevtimelimit\install\scriptfile.php file:

Jerror::raiseWarning ( null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning ( null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'JEvents has been disabled, please enable it first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'This Addon Requires JEvents Core to be installed.<br/>Please first install JEvents' . $rel );


3. Wrong key value in administrator\language\en-GB\en-GB.plg_jevents_jevtimelimit.ini file:
PLG_JEVENTS_JEVTIMELIMIT="Jevents - Agenda and Minutes" - wrong plugin name,
PLG_JEVENTS_JEVTIMELIMIT_FILTER_DATE_FORMAT_DESC="Allow filter modules to override these constraints?" - this should explain date formats.

4. Unused keys in administrator\language\en-GB\en-GB.plg_jevents_jevtimelimit.ini file:
PLG_JEVENTS_JEVTIMELIMIT_STARTING_AFTER_DESC
JEV_STARTING_AFTER

5. Keys in administrator\language\en-GB\en-GB.plg_jevents_jevtimelimit.ini file:
PLG_JEVENTS_JEVTIMELIMIT_FILTERS_MOVE_ERROR
PLG_JEVENTS_JEVTIMELIMIT_FILTERS_NOT_FOUND
should be moved to sys.ini - they are installation related.


Weekday Event Plugin

1. Hard coded string in plugins\jevents\jevweekdays\jevweekdays.xml file:

<name>JEvents - Weekday Restrictions</name>


2. Plugin description is not loading from JEVF_WEEKDAY_DESC key value when we install plugin (Installation of the plugin was successful.) and we can see key name only.
This key is available in ini file - it's possible that Joomla require sys.ini in this place.


Tabbed Module Plugin

1. Hard coded name in manifest modules\mod_tabbedmodules\mod_tabbedmodules.xml file:

<name>JEvents Tabbed Modules</name>

use JEV_TABBED_MOD key for that.

2. Hard coded strings in manifest modules\mod_tabbedmodules\mod_tabbedmodules.xml file:

<field name="tabbedorselect" type="radio" default="0" label="MOD_TABBEDMODULES_TABORSELECT" description="MOD_TABBEDMODULES_TABORSELECT_DESC"
class="btn-group">
<option value="0">Tabbed</option>
<option value="1">Dropdown</option>
<!-- <option value="2">Slider</option> //-->
</field>


3. Wrong key name in manifest modules\mod_tabbedmodules\mod_tabbedmodules.xml file:

<field name="preload" type="radio" default="0" label="MOD_TABBEDMODULES_PRELOADMODULES" description="IMOD_TABBEDMODULES_PRELOADMODULES_DESC"
class="btn-group">

should be:

<field name="preload" type="radio" default="0" label="MOD_TABBEDMODULES_PRELOADMODULES" description="MOD_TABBEDMODULES_PRELOADMODULES_DESC"
class="btn-group">


4. No installation options for sys.ini file:

<languages folder="language">
<language tag="en-GB">en-GB/en-GB.mod_tabbedmodules.ini</language>
</languages>

but it is present in zip file.

5. Unused keys in language\en-GB\en-GB.mod_tabbedmodules.sys.ini file:
JEV_METATAG
JEV_METATAG_INSTALL
JEV_METATAG_UPDATE

6. There are two keys with near same values in language\en-GB\en-GB.mod_tabbedmodules.sys.ini file:
MOD_TABBEDMODULES_DESC
JEV_TABBED_MOD_DESC
there is just need for one, modules\mod_tabbedmodules\install.php file:

echo JText::_('JEV_TABBED_MOD_DESC');
(...)
echo JText::_('JEV_TABBED_MOD_DESC');

this should be replaced with MOD_TABBEDMODULES_DESC and JEV_TABBED_MOD_DESC should be removed from language file.

10. If there is nothing selected in position, module shouldn't be visible at all or validate this before save. Also position control should be filled with positions from templates, as its done by Joomla it self.

11. I dont see a way other than CSS (display none) to hide modules that are gonna be visible in tabs...

12. To many strings at Transifex:
MOD_TABBEDMODULES_DATEFORMAT_DESC
MOD_TABBEDMODULES_DATEFORMAT

13. Hard coded strings in modules\mod_tabbedmodules\install.php file:

Jerror::raiseWarning ( null, 'JEvents Must be installed first to use this addon.');
(...)
Jerror::raiseWarning ( null, 'A minimum of JEvents V3.1.14 is required for this addon. <br/>Please update JEvents first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'JEvents has been disabled, please enable it first.' . $rel );
(...)
Jerror::raiseWarning ( null, 'This Addon Requires JEvents core to be installed.<br/>Please first install JEvents' . $rel );
8 years ago
·
#6550
0
Votes
Undo
Thank you for your AMAZING ongoing hard work on this - your hard work is really appreciated!

We are taking careful note of your comments and are incorporating them into the code.

JEvents Club members can get priority forum support at the Support Forum. As well as access to a variety of custom JEvents addons and benefits. Join the JEvents club today!

8 years ago
·
#6549
0
Votes
Undo
31. People / resource type allowed to save without a title - validation from pt. 55 doesn't work.
55 should be point 32.

Matching Events Summary Plugin

1. Hard coded strings in plugins\jevents\jevmatchingevents\jevmatchingevents.xml file:

<name>JEvents - Matching Events Summary</name>

could use MOD_JEVENTS_SLIDESHOW key which is ATM not used.

2. Duplicated keys in plugins\jevents\jevmatchingevents\language\en-GB\en-GB.plg_jevents_jevmatchingevents.sys.ini AND administrator\language\en-GB\en-GB.plg_jevents_jevmatchingevents.ini file:
JEV_MATCHINGEVENTS_DESC - should be in sys.ini only

Slideshow Module

1. Hard coded strings in modules\mod_jevents_slideshow\mod_jevents_slideshow.xml file:

<name>JEvents Slideshow</name>
(...)
<description>Allows showing events in a slider</description>


2. Result of code below - from modules\mod_jevents_slideshow\mod_jevents_slideshow.php file:

$jevfilesplugin = JPluginHelper::getPlugin('jevents', 'jevfiles');
if (!$jevfilesplugin) {
//JFactory::getApplication()->enqueueMessage("JEV_MAKE_SURE_IMAGE_DISPLAY_IN_LIST_VIEWS_IS_ENABLED_IN_STANDARD_IMAGES_PLUGIN","error");
echo JText::_("JEV_MAKE_SURE_IMAGE_DISPLAY_IN_LIST_VIEWS_IS_ENABLED_IN_STANDARD_IMAGES_PLUGIN");
return;
}
$jevfilesparams = new JRegistry($jevfilesplugin->params);
$inlist = $jevfilesparams->get("inlist",0);
if (!$inlist) {
//JFactory::getApplication()->enqueueMessage("JEV_MAKE_SURE_IMAGE_DISPLAY_IN_LIST_VIEWS_IS_ENABLED_IN_STANDARD_IMAGES_PLUGIN","error");
echo JText::_("JEV_MAKE_SURE_IMAGE_DISPLAY_IN_LIST_VIEWS_IS_ENABLED_IN_STANDARD_IMAGES_PLUGIN");
return;
}

should be visible ONLY for logged in administrators - ATM it is visible to everybody.
8 years ago
·
#6548
0
Votes
Undo
29. Key value JEVENTS_EXTRAS="JEvents Extras" should be changed to JEVENTS_EXTRAS="People/Resources" to get correct title in component.

30. Types list - 'select all' checkbox doesn't work.

31. People / resource type allowed to save without a title - validation from pt. 55 doesn't work.

32. People / resource saving issue - when title is empty and we want to save it it goes straight to list without any warning/error message.

33. When creating/editing people/resource, when 'link with joomla user' option is enabled (linktouser>0) control which would allow linking isn't an combobox (with users list) - its simple edit field, this control should be combobox for linktouser=1 (and linktouser=2 ? - not sure how this option work in this state...) and multi select combobox for linktouser=3. ATM only way to select user is to type it manually, also in this state control will not accept multiple users 'user1,user2' will be saved as 'user1'.

34. DB table field attrib of 'People / resource type' 'title' field - should it be "unique"? ATM it allow duplicates - when selecting people/resource type it can lead to confusion. If how to proceede when updating table... it will not allow to add unique attib if field values aren't unique...

35. This code in administrator\components\com_jevpeople\views\people\view.html.php file needs to be checked:

function edit($tpl = null)
(...)
// Set toolbar items for the page
$edit = JRequest::getVar('edit', true);
$text = !$edit ? JText::_('NEW') : JText::_('NEW');

ATM $edit is always true if we edit or create new - when fixed, $text value should be corrected to return either 'NEW' or 'EDIT' key values for correct title (ATM key NEW is missing from language files and should be added).

36. Option COM_JEVPEOPLE_CHECKOVERLAPS in people/resource edit form NEEDS a description.
8 years ago
·
#6547
0
Votes
Undo
16. Hard coded string in administrator\components\com_jevpeople\views\people\tmpl\list.php file:

<?php echo JHtml::_('grid.sort', 'Type', 'pt.title', $this->lists['order_Dir'], $this->lists['order'] , "people.list"); ?>

PEOPLE_TYPE or PERSON_TYPE key could be used.

17. Hard coded string in administrator\components\com_jevpeople\views\people\tmpl\edit.php file:

<?php echo JHTML::tooltip(JText::_('FULL_URL'), "", "", 'Website'); ?>:

should be:

<?php echo JHTML::tooltip(JText::_('FULL_URL'), "", "", JText::_('Website')); ?>:


18. Hard coded string in administrator\components\com_jevpeople\views\people\tmpl\edit.php file:

<label for="postcode">
<?php echo JText::_('Postcode/Zip'); ?>:
</label>

should be changed to:

<label for="postcode">
<?php echo JText::_(POSTCODE); ?>:
</label>


19. Missing key definitions:
COM_JEVPEOPLE_CATEGORIES_CREATE_DESC
COM_JEVPEOPLE_CATEGORIES_DELETE_DESC
COM_JEVPEOPLE_CATEGORIES_EDITSTATE_DESC
COM_JEVPEOPLE_CATEGORIES_EDIT_DESC
used in administrator\components\com_jevpeople\access.xml file.

20. Missing key definitions:
JACTION_EDIT_STATE
used in administrator\components\com_jevpeople\access.xml file.

21. Duplicate keys in administrator\language\en-GB\en-GB.com_jevpeople.ini AND administrator\language\en-GB\en-GB.com_jevpeople.sys.ini files:
COM_JEVPEOPLE_LIST_PEOPLE_TMPL_TITLE
COM_JEVPEOPLE_LIST_PEOPLE_TMPL_DESC
COM_JEVPEOPLE_MANAGE_PEOPLE_TMPL_TITLE
COM_JEVPEOPLE_MANAGE_PEOPLE_TMPL_DESC
COM_JEVPEOPLE_LIST_PEOPLE_BLOG_TMPL_TITLE
COM_JEVPEOPLE_LIST_PEOPLE_BLOG_TMPL_DESC

22. Duplicate keys in administrator\language\en-GB\en-GB.com_jevpeople.ini file:
JEV_PEOPLE_STREET
JEV_PEOPLE_PUBLIC_LIST

23. Unused keys in administrator\language\en-GN\en-GB.plg_search_jevpeoplesearch.ini file:
PEOPLE_SEARCH_DESC
SEARCH_LIMIT
SEARCH_LIMIT_DESC
SEARCH_PRIVATE
SEARCH_PRIVATE_DESC

24. Unused keys in administrator\language\en-GB\en-GB.com_jevpeople.sys.ini file:
JEVPEOPLE

25. Unused keys in administrator\language\en-GB\en-GB.com_jevpeople.ini file:
MAKE_GLOBAL
IMAGE_1
PEOPLE
JEV_ADMIN_CPANEL
JEV_ADMIN_CATSUPDATED
GOOGLE_MAP_LOOKUP_EXPLANATIION
SELECT_STATE
CHOOSE_CITY
USER
JEV_REQUIRED

26. Protocol change in administrator\components\com_jevpeople\views\types\view.html.php file:
from

$googleurl = $compparams->get("googlemaps", 'http://maps.google.com');

to

$googleurl = $compparams->get("googlemaps", 'https://maps.google.com');


27. Wrong key used in administrator\components\com_jevpeople\views\types\tmpl\edit.php file:

<td width="100" align="right" class="key">
<label for="title">
<?php echo JText::_( 'MULTIPLE_PER_EVENT' ); ?>:
</label>
</td>
<td>
<?php echo $this->multiple;?>
</td>

should be:

<td width="100" align="right" class="key">
<label for="title">
<?php echo JText::_( 'NUMBERS_PER_EVENT' ); ?>:
</label>
</td>
<td>
<?php echo $this->multiple;?>
</td>


28. Some code corrections in administrator\components\com_jevpeople\views\types\tmpl\edit.php file:
a) should it be commented?

<!--
<tr>
<td width="100" align="right" class="key">
<label for="title">
<?php echo JText::_( 'MAX_NUMBERS_PER_EVENT' ); ?>:
</label>
</td>
<td>
<?php echo $this->maxnumber;?>
</td>
</tr>
//-->

b) make LAYOUT_IN_EVENT_DETAIL_OUTPUT_TIP real tooltip not some another label:

<label for="title">
<?php echo JText::_( 'LAYOUT_IN_EVENT_DETAIL_OUTPUT' ); ?>:
</label>
<br/>
<em><?php echo JText::_( 'LAYOUT_IN_EVENT_DETAIL_OUTPUT_TIP' ); ?></em>

change it to something like this:

<label title="<strong><?php echo JText::_( 'LAYOUT_IN_EVENT_DETAIL_OUTPUT' ); ?></strong><br/><?php echo JText::_( 'LAYOUT_IN_EVENT_DETAIL_OUTPUT_TIP' ); ?>" class="hasTooltip" for="title">
<?php echo JText::_( 'LAYOUT_IN_EVENT_DETAIL_OUTPUT' ); ?>
</label>
8 years ago
·
#6546
0
Votes
Undo
Managed People / Resources Plugin

1. Hard coded strings in manifest administrator\manifests\packages\pkg_jevpeople.xml file:

<name>JEvents Managed People/Resources Package</name>
(...)
<description>JEvents People - Managed people and resources for JEvents</description>

(solution for language files for packages - just in case if... ;) ).

2. Hard coded strings in manifest administrator\components\com_jevpeople\manifest.xml file:

<name>JEV People</name>
(...)
<description>Managed People Extension for JEvents</description>


3. Hard coded strings in plugins\content\jevpeople\jevpeople.xml file:

<name>JEvents - Events for people</name>
(...)
<description>Displays summary (in latest events format) of events associated with person. Usage {jevp}27{/jevp} to show list of events associated iwht managed person 27.</description>
(...)

AND MANY MORE !!!



4. Hard coded strings in plugins\jevents\jevpeople\jevpeople.xml file:

<name>JEvents - Managed People</name>
(...)
<description>Assign People/Organizations from a managed list to event details. Assign artists or booking agencies to an event.</description>


5. Hard coded string in manifest plugins\search\jevpeoplesearch\jevpeoplesearch.xml file:

<name>Search - JEvents People/Resources</name>
(...)
<description>PEOPLE_SEARCH_DESC</description>

PEOPLE_SEARCH_DESC should be changed to PLG_JEVENTS_JEVPEOPLESEARCH_DESC and then be removed.

6. Hard coded strings in administrator\components\com_jevpeople\config.xml file:

<field name="layout" type="text" default="" label='OVERRIDE_LAYOUT' description="Specify Template Override Layout Name e.g. detail2 or calendar2"/>
(...)
<field name="jevview" type="list" default="month.calendar" label='JEV_PEOPLE_JEVENTS_VIEW' description="If linking to events - which view? Only used if target menu item is not set or is not a JEvents menu item">
(...)
<field name="jevview" type="list" default="month.calendar" label='JEV_PEOPLE_JEVENTS_VIEW' description="If linking to events - which view? Only used if target menu item is not set or is not a JEvents menu item">

should use JEV_PEOPLE_JEVENTS_VIEW_DESC for the JEV_PEOPLE_JEVENTS_VIEW description.

7. Hard coded string in components\com_jevpeople\views\people\tmpl\people.xml AND components\com_jevpeople\views\people\tmpl\people_blog.xml files:

<field name="jevview" type="list" default="month.calendar" label='JEV_PEOPLE_JEVENTS_VIEW' description="If linking to events - which view? Only used if target menu item is not set or is not a JEvents menu item">

JEV_PEOPLE_JEVENTS_VIEW_DESC key should be used.

8. Hard coded string in administrator\components\com_jevpeople\views\categories\view.html.php file:

JToolBarHelper::custom( 'cpanel.cpanel', 'default.png', 'default.png', 'CONTROL PANEL', false );

should be changed to CONTROL_PANEL key.

9. Hard coded strings in administrator\components\com_jevpeople\views\people\view.html.php AND files:

JToolBarHelper::deleteList("Are you sure you want to delete these people?", "people.delete");
(...)
JToolBarHelper::cancel('cpanel.show', 'Control Panel');

second string should be changed to CONTROL_PANEL key.

10. Hard coded strings in administrator\components\com_jevpeople\views\types\view.html.php file:

JToolBarHelper::deleteList("Are you sure you want to delete these types?", "types.delete");
(...)
JToolBarHelper::cancel('cpanel.show', 'Control Panel');


second string should be changed to CONTROL_PANEL key.

11. Hard coded string in administrator\components\com_jevpeople\views\categories\tmpl\edit.php file:

<?php echo $this->typeFilter(true,"onchange='alert(\"You must save this category after changing its type to see the correct category list\");'");?>


12. Hard coded string in administrator\components\com_jevpeople\views\categories\tmpl\overview.php file:

<a href="/j_avascript: saveCategoryOrder( <?php echo count( $this->cats )-1; ?> )"><img src="/images/filesave.png" border="0" width="16" height="16" alt="Save Order" /></a>

(modified js to be able to post it)

13. Hard coded strings in administrator\components\com_jevpeople\views\people\view.html.php file:

$this->toolbarButton("people.save", "save", "save", "Save", false);
if (!$edit)
{
$this->toolbarButton("people.cancel", "cancel", "cancel", "Cancel", false);
}
else
{
// for existing items the button is renamed `close`
$this->toolbarButton("people.cancel", "cancel", "cancel", "Close", false);
}
(...)
$lists["type"] = JHTML::_('select.genericlist', $options, 'type_id', 'class="inputbox" size="1" onchange="alert(\'You must save the person and re-edit to show the correct category options\');" ', 'type_id', 'title', $person->type_id);


14. Hard coded strings in administrator\components\com_jevpeople\views\types\view.html.php file:

$this->toolbarButton("types.save", "save", "save", "Save", false);
if (!$edit)
{
$this->toolbarButton("types.cancel", "cancel", "cancel", "Cancel", false);
}
else
{
// for existing items the button is renamed `close`
$this->toolbarButton("types.cancel", "cancel", "cancel", "Close", false);
}


15. Hard coded strings in administrator\components\com_jevpeople\views\people\tmpl\edit.php AND administrator\components\com_jevpeople\views\types\tmpl\edit.php files:

if (form.title.value == ""){
alert( "<?php echo JText::_('Person must have a title', true); ?>" );
}

should be changed to JEV_E_WARNTITLE on new key.
8 years ago
·
#6545
0
Votes
Undo
30. Unused keys in location embed language administrator\language\en-GB\en-GB.plg_content_jevlocation_embed.ini file:
JEV_REDUCE_ZOOM and JEV_REDUCE_ZOOM_TIP - (PLG_JEVENTS_JEVLOCATIONS_REDUCE_ZOOM_LABEL, PLG_JEVENTS_JEVLOCATIONS_REDUCE_ZOOM_DESC keys are used in xml file),
JEV_POPUP_WIDTH and JEV_POPUP_HEIGHT - (PLG_JEVENTS_JEVLOCATIONS_POPUP_WIDTH_LABEL, PLG_JEVENTS_JEVLOCATIONS_POPUP_HEIGHT_LABEL keys are used in xml file),
JEV_SHOW_DESC and JEV_SHOW_DESC_TIP - (PLG_JEVENTS_JEVLOCATIONS_SHOW_DESCRIPTION_LABEL, PLG_JEVENTS_JEVLOCATIONS_SHOW_DESCRIPTION_DESC keys are used in xml file),
JEV_GOOGLE_MAP_WIDTH and JEV_GOOGLE_MAP_HEIGHT - (PLG_JEVENTS_JEVLOCATIONS_GOOGLE_MAP_WIDTH_LABEL, PLG_JEVENTS_JEVLOCATIONS_GOOGLE_MAP_HEIGHT_LABEL keys are used in xml file),
JEV_LOCATION_LAYOUT and JEV_LOCATION_LAYOUT_DESC - (PLG_JEVENTS_JEVLOCATIONS_LOCATION_LAYOUT_LABEL, PLG_JEVENTS_JEVLOCATIONS_LOCATION_LAYOUT_DESC keys are used in xml file).

31. If location title is empty error message is shown but not editor form controls.

32. "Control panel" link visible in Country/State/City list - this is unnecessary as there is button in help toolbar.

33. Menu locations list filter by city/region should be multiselect combobox control rather than comma separated string (like one by category) for better usability.

34. Document expired message when category title is empty and error message is shown (JEV_ERR_CAT_MUST_HAVE_NAME) that is raised in check() function in administrator\components\com_jevlocations\libraries\catClass.php AND administrator\components\com_jevlocations\libraries\categoryClass.php files (this is similar to posted earlier error with Tags plugin).

35. "Display Mode" control is missing from options in "List Locations - Blog Layout" AND "List Locations" menu item types (however there are "Display Events of the next days" controls).

36 Missing key LOC SEARCH DESC used in plugins\search\jevlocsearch\jevlocsearch.xml file - old Transifex resources?

ps. there may be additional posts regarding Locations later.
8 years ago
·
#6544
0
Votes
Undo
27. Duplicate keys withing en-GB.com_jevlocations.ini file:
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_LABEL
COM_JEVLOCATIONS_FIELD_MAXIMUM_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_MAXIMUM_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_OVERRIDE_LAYOUT_DESC
COM_JEVLOCATIONS_FIELD_OVERRIDE_LAYOUT_LABEL
COM_JEVLOCATIONS_FIELD_SHOW_FILTERS_DESC
COM_JEVLOCATIONS_FIELD_SHOW_FILTERS_LABEL
COM_JEVLOCATIONS_FIELD_SHOW_MULTIMAP_DESC
COM_JEVLOCATIONS_FIELD_SHOW_MULTIMAP_LABEL
COM_JEVLOCATIONS_FIELD_SORT_REVERSE_DESC
COM_JEVLOCATIONS_FIELD_SORT_REVERSE_LABEL
COM_JEVLOCATIONS_FIELD_USE_SETTINGS_DESC
COM_JEVLOCATIONS_FIELD_USE_SETTINGS_LABEL

28. Unused keys in language\en-GB\en-GB.com_jevlocations.ini file:
(most of this keys are same as in point 24 for admin)
JEV_LOCATION_CATEGORIES
JEV_E_WARNTITLE
GOOGLE_MAP_LOOKUP_EXPLANATIION
CLICK_MAP
ALL_CITIES
ANY_LOCATION
MY_LOCATIONS
COMMON_LOCATIONS
LINK_TO_MATCHING_EVENTS
JEV_SHOWPRIORITY
JEV_SHOWPRIORITY_TIP
JEV_ANON_CREATE
JEV_ANON_CREATE_DESC
JEV_ANON_SELECT
JEV_ANON_SELECT_DESC
JEV_ANON_PUBLISHED
JEV_ANON_PUBLISHED_DESC
JEV_LOCSAVED_REVIEWED
JEV_ADMIN
JEV_ADMIN_DESC
JEV_ANON_SUBJECT
JEV_ANON_MESSAGE
JEV_ANON_MESSAGE_DESC
JEV_ANON_MESSAGE_DEFAULT
JEV_ANON_PUBLISHED
JEV_ANON_PUBLISHED_DESC
JEV_LOCSAVED_REVIEWED
JEV_ADMIN
JEV_ADMIN_DESC
JEV_ANON_SUBJECT
JEV_ANON_MESSAGE
JEV_ANON_MESSAGE_DESC
JEV_ANON_MESSAGE_DEFAULT
JEV_LIST_ORDER_DESC
JEV_COUNTRY_STATE_CITY_TITLE
JEV_IMPORT_LOCATIONS
JEV_IMPORT_LOCATIONS_DESC
JEV_SHOW_MULTIMAP
JEV_SHOW_MULTIMAP_DESC
GOOGLE_MAPS_API_DOMAIN
GOOGLE_MAPS_API_DOMAIN_DESC
GOOGLE_MAPS_API_EXTRA_KEY
GOOGLE_MAPS_API_EXTRA_URL
JEV_LOCATION_CATEGORY_FILTER
JEV_LOCATION_CATEGORY_FILTER_DESC
JEV_FIELD_TEMPLATE
JEV_FIELD_TEMPLATE_DESC
JEV_REQUIRED
JEV_UPLOAD_IMAGES
JEV_UPLOAD_IMAGES_TIP
JEV_UPLOAD_MAX_SIZE
JEV_UPLOAD_MAX_SIZE_TIP
JEV_SCALED_WIDTH
JEV_SCALED_WIDTH_TIP
JEV_SCALED_HEIGHT
JEV_SCALED_HEIGHT_TIP
THUMBNAIL_WIDTH
THUMBNAIL_WIDTH_TIP
THUMBNAIL_HEIGHT
THUMBNAIL_HEIGHT_TIP
MAX_SIZE_FOR_THUMBNAIL
MAX_SIZE_FOR_THUMBNAIL_TIP
JEV_SHOW_IMAGES
JEV_SHOW_IMAGES_DESC
JEV_SHOW_FILTERS
JEV_SHOW_FILTERS_DESC
JEV_SELECT_FROM_ALL
JEV_SELECT_FROM_ALL_TIP
JEV_GLOBAL_BY_DEFAULT
JEV_GLOBAL_BY_DEFAULT_TIP
JEV_DIRECT_TO_GOOGLE_DIRECTIONS
JEV_DIRECT_TO_GOOGLE_DIRECTIONS_DESC
JGLOBAL_NEWITEMSFIRST_DESC
JGLOBAL_NEWITEMSLAST_DESC
JTOOLBAR_PUBLISH
JTOOLBAR_UNPUBLISH
JTOOLBAR_DELETE
JTOOLBAR_EDIT
JTOOLBAR_NEW

29. Same values in keys within site\admin language\en-GB\en-GB.com_jevlocations.ini files (this should be standarized):
GEO_LAT <=======> COM_JEVLOCATIONS_GEO_LAT_LBL
GEO_LON <=======> COM_JEVLOCATIONS_GEO_LONG_LBL
GEO_ZOOM <=======> COM_JEVLOCATIONS_GEO_ZOOM_LBL
ADDRESS <=======> COM_JEVLOCATIONS_ADDRESS_LBL
ORDERING <=======> COM_JEVLOCATIONS_ORDERING_LBL
GLOBAL <=======> COM_JEVLOCATIONS_GLOBAL_LBL
CHOOSE_CITY <=======> COM_JEVLOCATIONS_CHOOSE_CITY_LBL
ALIAS <=======> COM_JEVLOCATIONS_ALIAS_LBL
NAME <=======> COM_JEVLOCATIONS_NAME_LBL
STREET <=======> COM_JEVLOCATIONS_STREET_LBL
RESET <=======> COM_JEVLOCATIONS_RESET
STATE <=======> COM_JEVLOCATIONS_STATE
GOOGLE_MAP <=======> COM_JEVLOCATIONS_GOOGLE_MAP_LBL
FIND_ADDRESS <=======> COM_JEVLOCATIONS_FIND_ADDRESS_LBL
DESCRIPTION <=======> COM_JEVLOCATIONS_DESCRIPTION_LBL
URL <=======> COM_JEVLOCATIONS_URL_LBL
LINK_TO_MATCHING_EVENTS <=======> COM_JEVLOCATIONS_FIELD_LINK_TO_MATCHING_EVENTS_LABEL
8 years ago
·
#6543
0
Votes
Undo
26. Duplicate keys in en-GB.com_jevlocations.sys AND en-GB.com_jevlocations.sys.ini files, (as I checked, keys in 'ini' override those in 'sys.ini' - so there is no need for both files to have them, should stay in ONE file - but in which one...)
COM_JEVLOCATIONS
COM_JEVLOCATIONS_COUNTRY_STATE_CITY
COM_JEVLOCATIONS_DETAIL_LAYOUT_TMPL_DESC
COM_JEVLOCATIONS_DETAIL_LAYOUT_TMPL_TITLE
COM_JEVLOCATIONS_EDIT_LAYOUT_TMPL_DESC
COM_JEVLOCATIONS_EDIT_LAYOUT_TMPL_TITLE
COM_JEVLOCATIONS_EDIT_LOCATION_DESC
COM_JEVLOCATIONS_EDIT_LOCATION_TITLE
COM_JEVLOCATIONS_FIELD_ADDITIONAL_CATEGORY_DESC
COM_JEVLOCATIONS_FIELD_ADDITIONAL_CATEGORY_LABEL
COM_JEVLOCATIONS_FIELD_ADDITIONAL_CONSTRAINTS_DESC
COM_JEVLOCATIONS_FIELD_ADDITIONAL_CONSTRAINTS_LABEL
COM_JEVLOCATIONS_FIELD_CHECK_FOR_AFTER_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_CHECK_FOR_AFTER_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_CHECK_FOR_BEFORE_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_CHECK_FOR_BEFORE_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_CHECK_FOR_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_CHECK_FOR_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_DISABLE_CSS_DESC
COM_JEVLOCATIONS_FIELD_DISABLE_CSS_LABEL
COM_JEVLOCATIONS_FIELD_DISABLE_CSS_TITLE_DESC
COM_JEVLOCATIONS_FIELD_DISABLE_CSS_TITLE_LABEL
COM_JEVLOCATIONS_FIELD_DISPLAY_AS_LINKS_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_AS_LINKS_LABEL
COM_JEVLOCATIONS_FIELD_DISPLAY_CALENDAR_LINK_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_CALENDAR_LINK_LABEL
COM_JEVLOCATIONS_FIELD_DISPLAY_CALENDAR_VALUE_FIRST_LINE
COM_JEVLOCATIONS_FIELD_DISPLAY_CALENDAR_VALUE_LAST_LINE
COM_JEVLOCATIONS_FIELD_DISPLAY_EVENTS_NEXT_DAYS_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_EVENTS_NEXT_DAYS_LABEL
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_LABEL
COM_JEVLOCATIONS_FIELD_DISPLAY_REPEATING_EVENT_ONCE_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_REPEATING_EVENT_ONCE_LABEL
COM_JEVLOCATIONS_FIELD_DISPLAY_YEARS_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_YEARS_LABEL
COM_JEVLOCATIONS_FIELD_HIDE_LINKS_DESC
COM_JEVLOCATIONS_FIELD_HIDE_LINKS_LABEL
COM_JEVLOCATIONS_FIELD_INCLUDE_EVENTS_LATEST_CSS_DESC
COM_JEVLOCATIONS_FIELD_INCLUDE_EVENTS_LATEST_CSS_LABEL
COM_JEVLOCATIONS_FIELD_JEVENTS_VIEW_DESC
COM_JEVLOCATIONS_FIELD_JEVENTS_VIEW_LABEL
COM_JEVLOCATIONS_FIELD_JEVENTS_VIEW_VALUE_DAY_LIST
COM_JEVLOCATIONS_FIELD_JEVENTS_VIEW_VALUE_MONTHLY_CALENDAR
COM_JEVLOCATIONS_FIELD_JEVENTS_VIEW_VALUE_WEEK_LIST
COM_JEVLOCATIONS_FIELD_JEVENTS_VIEW_VALUE_YEAR_LIST
COM_JEVLOCATIONS_FIELD_LINK_TO_MATCHING_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_LINK_TO_MATCHING_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_LOCATIONS_ADDITIONAL_CONSTRAINTS_TEXT
COM_JEVLOCATIONS_FIELD_LOCATIONS_DETAIL_TEXT
COM_JEVLOCATIONS_FIELD_LOCATIONS_LIST_TEXT
COM_JEVLOCATIONS_FIELD_LOCATION_CATEGORY_FILTER_DESC
COM_JEVLOCATIONS_FIELD_LOCATION_CATEGORY_FILTER_LABEL
COM_JEVLOCATIONS_FIELD_LOCATION_CITY_FILTER_DESC
COM_JEVLOCATIONS_FIELD_LOCATION_CITY_FILTER_LABEL
COM_JEVLOCATIONS_FIELD_LOCATION_STATE_FILTER_DESC
COM_JEVLOCATIONS_FIELD_LOCATION_STATE_FILTER_LABEL
COM_JEVLOCATIONS_FIELD_LOCK_CATEGORY_FILTERS_DESC
COM_JEVLOCATIONS_FIELD_LOCK_CATEGORY_FILTERS_LABEL
COM_JEVLOCATIONS_FIELD_MAXIMUM_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_MAXIMUM_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_ONLY_GLOBAL_DESC
COM_JEVLOCATIONS_FIELD_ONLY_GLOBAL_LABEL
COM_JEVLOCATIONS_FIELD_ONLY_WITH_EVENTS_DESC
COM_JEVLOCATIONS_FIELD_ONLY_WITH_EVENTS_LABEL
COM_JEVLOCATIONS_FIELD_OVERRIDE_LAYOUT_DESC
COM_JEVLOCATIONS_FIELD_OVERRIDE_LAYOUT_LABEL
COM_JEVLOCATIONS_FIELD_SHOW_FILTERS_DESC
COM_JEVLOCATIONS_FIELD_SHOW_FILTERS_LABEL
COM_JEVLOCATIONS_FIELD_SHOW_MULTIMAP_DESC
COM_JEVLOCATIONS_FIELD_SHOW_MULTIMAP_LABEL
COM_JEVLOCATIONS_FIELD_SORT_REVERSE_DESC
COM_JEVLOCATIONS_FIELD_SORT_REVERSE_LABEL
COM_JEVLOCATIONS_FIELD_SPECIFIED_CATEGORY_DESC
COM_JEVLOCATIONS_FIELD_SPECIFIED_CATEGORY_LABEL
COM_JEVLOCATIONS_FIELD_TARGET_MENU_ITEM_DESC
COM_JEVLOCATIONS_FIELD_TARGET_MENU_ITEM_LABEL
COM_JEVLOCATIONS_FIELD_USE_SETTINGS_DESC
COM_JEVLOCATIONS_FIELD_USE_SETTINGS_LABEL
COM_JEVLOCATIONS_FIELD_USE_SETTINGS_VALUE_BELOW_SETTINGS
COM_JEVLOCATIONS_FIELD_USE_SETTINGS_VALUE_COMPONENT_SETTINGS
COM_JEVLOCATIONS_LIST_LOCATIONS_BLOG_TMPL_DESC
COM_JEVLOCATIONS_LIST_LOCATIONS_BLOG_TMPL_TITLE
COM_JEVLOCATIONS_LIST_LOCATIONS_DESC
COM_JEVLOCATIONS_LIST_LOCATIONS_TITLE
COM_JEVLOCATIONS_LIST_LOCATIONS_TMPL_DESC
COM_JEVLOCATIONS_LIST_LOCATIONS_TMPL_TITLE
COM_JEVLOCATIONS_LOCATION_CATEGORIES
COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_DESC
COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_TITLE
8 years ago
·
#6542
0
Votes
Undo
18. COM_PLUGINS_CONTENT_JEVLOCATION_EMBED_INSTRUCTIONS_FIELDSET_LABEL key defined in 'location embed' language file should be renamed to JGLOBAL_FIELDSET_CONTENT_JEVLOCATION_EMBED_INSTRUCTIONS.

19 ALERTNOTAUTH key should be changed in administrator\components\com_jevlocations\models\location.php file with COM_JEVLOCATIONS_NOT_AUTHORISED (imo) and ALERTNOTAUTH removed then.

20. COM_JEVLOCATIONS_SHOW_LOCATION_LATEST_EVENTS_LABEL is missing from administrator language files (only in site files).

21. Unknown context for translation of COM_JEVLOCATIONS_USE_GLOBAL="Use Global" key usage in this code:

<field name="showmap" type="list" default="" label="COM_JEVLOCATIONS_FIELD_SHOW_MULTIMAP_LABEL" description="COM_JEVLOCATIONS_FIELD_SHOW_MULTIMAP_DESC">
<option value="">COM_JEVLOCATIONS_USE_GLOBAL</option>
<option value="1">JEV_YES</option>
<option value="0">JEV_NO</option>
</field>

require some clarification.

22. Unused keys declared in administrator\language\en-GB\en-GB.plg_content_jevlocation_embed.ini file:
JEV_REDUCE_ZOOM
JEV_REDUCE_ZOOM_TIP
JEV_POPUP_WIDTH
JEV_POPUP_HEIGHT
SELECT_PERSON
JEV_SELECT
JEV_SHOW_DESC
JEV_SHOW_DESC_TIP
JEV_GOOGLE_MAP_WIDTH
JEV_GOOGLE_MAP_HEIGHT
JEV_LOCATION_LAYOUT
JEV_LOCATION_LAYOUT_DESC
JEV_MAP_TYPE
JEV_GOOGLE_ROAD
JEV_GOOGLE_HYBRID
JEV_GOOGLE_SATELLITE
JEV_DETAIL_POPUP
JEV_DETAIL_POPUP_TIP
JEV_ALWAYS_LINK_CATEGORY_TABLE
JEV_ALWAYS_LINK_CATEGORY_TABLE_TIP
JEV_AVAILABLE_IN_LISTS
JEV_AVAILABLE_IN_LISTS_DESC
JEV_DEFAULT_COUNTRY
JEV_DEFAULT_COUNTRY_TIP

23. Unused keys declared in administrator\language\en-GB\en-GB.pkg_jevlocations.sys.ini file:
COM_JEVENTS_OLDER_3_1_14

24. Unused keys declared in administrator\languages\en-GB\en-GB.com_jevlocations.ini:
COM_JEVLOCATIONS_FIELD_LOCATIONS_LIST_TEXT
COM_JEVLOCATIONS_BY_DAY_NUMBER
COM_JEVLOCATIONS_CREATE_LOCATION
COM_JEVLOCATIONS_DATE_FORMAT
COM_JEVLOCATIONS_EMAIL_TO_AUTHOR
COM_JEVLOCATIONS_FIELD_ANON_MESSAGE_CONTENT
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_DESC
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_VALUE_0
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_VALUE_1
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_VALUE_2
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_VALUE_3
COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_VALUE_4
COM_JEVLOCATIONS_FIELD_LOC_GLOBAL_DESC
COM_JEVLOCATIONS_FIELD_LOC_GLOBAL_LABEL
COM_JEVLOCATIONS_FIELD_LOC_OWN_DESC
COM_JEVLOCATIONS_FIELD_LOC_OWN_LABEL
COM_JEVLOCATIONS_FIELD_UPLOAD_IMAGES_DESC
COM_JEVLOCATIONS_FIELD_UPLOAD_IMAGES_LABEL
COM_JEVLOCATIONS_REPEAT_WEEK
COM_JEVLOCATIONS_SEARCH_TITLE
COM_JEVLOCATIONS_SELECT_CATEGORY
COM_JEVLOCATIONS_SELECT_EDITOR
COM_JEVLOCATIONS_SELECT_FROM_ALL
COM_JEVLOCATIONS_SELECT_MENU
COM_JEVLOCATIONS_SELECT_USER
COM_JEVLOCATIONS_TITLE_CLICK_TO_SELECT
COM_JEVLOCATIONS_VIEW_BY_CATEGORY
COM_JEVLOCATIONS_VIEW_BY_DAY
COM_JEVLOCATIONS_VIEW_BY_MONTH
COM_JEVLOCATIONS_VIEW_BY_WEEK
COM_JEVLOCATIONS_VIEW_BY_YEAR
COM_JEVLOCATIONS_WARNNAMETRYAGAIN
COM_JEVLOCATIONS_NAME_LBL
COM_JEVLOCATIONS_NAME_DESC
COM_JEVLOCATIONS_URL_LBL
COM_JEVLOCATIONS_GLOBAL_LBL
COM_JEVLOCATIONS_ADDRESS_LBL
NAME
JEVENTS_LOCATION_MANAGER
LINK_TO_MATCHING_EVENTS
JEV_SHOWPRIORITY
JEV_SHOWPRIORITY_TIP
JEV_ANON_CREATE
JEV_ANON_CREATE_DESC
JEV_ANON_SELECT
JEV_ANON_SELECT_DESC
JEV_ANON_PUBLISHED
JEV_ANON_PUBLISHED_DESC
JEV_LOCSAVED_REVIEWED
JEV_ADMIN
JEV_ADMIN_DESC
JEV_ANON_SUBJECT
JEV_ANON_MESSAGE
JEV_ANON_MESSAGE_DESC
JEV_ANON_MESSAGE_DEFAULT
JEV_LIST_ORDER_DESC
JEV_COUNTRY_STATE_CITY_TITLE
JEV_IMPORT_LOCATIONS
JEV_IMPORT_LOCATIONS_DESC
JEV_SHOW_MULTIMAP
JEV_SHOW_MULTIMAP_DESC
GOOGLE_MAPS_API_DOMAIN
GOOGLE_MAPS_API_DOMAIN_DESC
GOOGLE_MAPS_API_EXTRA_KEY
GOOGLE_MAPS_API_EXTRA_URL
JEV_LOCATION_CATEGORY_FILTER
JEV_LOCATION_CATEGORY_FILTER_DESC
JEV_FIELD_TEMPLATE
JEV_FIELD_TEMPLATE_DESC
JEV_REQUIRED
JEV_UPLOAD_IMAGES
JEV_UPLOAD_IMAGES_TIP
JEV_UPLOAD_MAX_SIZE
JEV_UPLOAD_MAX_SIZE_TIP
JEV_SCALED_WIDTH
JEV_SCALED_WIDTH_TIP
JEV_SCALED_HEIGHT
JEV_SCALED_HEIGHT_TIP
THUMBNAIL_WIDTH
THUMBNAIL_WIDTH_TIP
THUMBNAIL_HEIGHT
THUMBNAIL_HEIGHT_TIP
MAX_SIZE_FOR_THUMBNAIL
MAX_SIZE_FOR_THUMBNAIL_TIP
JEV_SHOW_IMAGES
JEV_SHOW_IMAGES_DESC
JEV_SHOW_FILTERS
JEV_SHOW_FILTERS_DESC
JEV_SELECT_FROM_ALL
JEV_SELECT_FROM_ALL_TIP
JEV_GLOBAL_BY_DEFAULT
JEV_GLOBAL_BY_DEFAULT_TIP
JEV_DIRECT_TO_GOOGLE_DIRECTIONS
JEV_DIRECT_TO_GOOGLE_DIRECTIONS_DESC
RESOURCE_NOT_FOUND
COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_DESC
COM_JEVLOCATIONS_FIELD_ADDITIONAL_CATEGORY_LABEL
COM_JEVLOCATIONS_FIELD_ADDITIONAL_CATEGORY_DESC
COM_JEVLOCATIONS_BATCH_OPTIONS
COM_JEVLOCATIONS_BATCH_TIP
COMJEVLOCATIONS_CHOOSE_CITY_BATCH_TITLE

25. Unused keys declared in administrator\languages\en-GB\en-GB.plg_search_jevlocsearch.ini file:
PLG_JEVENTS_JEVLOCSEARCH_DESC
PLG_JEVENTS_JEVLOCSEARCH_SEARCH_PRIVATE_LABEL
PLG_JEVENTS_JEVLOCSEARCH_SEARCH_PRIVATE_DESC
LOC_SEARCH_DESC
SEARCH_LIMIT
SEARCH_LIMIT_DESC
SEARCH_PRIVATE
SEARCH_PRIVATE_DESC
PLG_JEVENTS_JEVLOCSEARCH
8 years ago
·
#6541
0
Votes
Undo
3. Hard coded strings in administrator\components\com_jevlocations\views\locations\view.html.php file:

JToolBarHelper::deleteList("Are you sure you want to delete these locations?", "locations.delete");
(...)
JToolBarHelper::cancel('cpanel.cpanel', 'Control Panel');

second one should be changed to:

JToolBarHelper::cancel('cpanel.cpanel', 'CONTROL_PANEL');


4. Hard coded strings in administrator\components\com_jevlocations\views\categories\tmpl\overview.php AND administrator\components\com_jevlocations\views\cats\tmpl\overview.php file:

alert("You cannot change the order of items, as an item in the list is `Checked Out`");
(...)
<th width="2%"> Order</th>
(...)
echo '<a href="/: saveCategoryOrder( '. (count( $this->cats)-1) .' )"><img src="'.$pathIMG . $img.'" width="16" height="16" border="0" alt="Save Order" /></a>';

(files have similar code so no need to post both),

(had to modify this code slightly to be able to post it).

5. Hard coded strings in components\com_jevlocations\controllers\findlocation.php file - in ALL throwerror messages.

6. Hard coded strings in administrator\components\com_jevlocations\config.xml file:

<field
name="scale"
type="radio"
class="btn-group"
default='km'
label='JEV_DISTANCE_SCALE'
description='JEV_DISTANCE_SCALE_TIP' >
<option value="km">Km</option>
<option value="miles">Miles</option>
</field>

'km' is standard abbreviation but 'miles' aren't, this needs to be connected to geofilter distance value.

7. Hard coded strings in components\com_jevlocations\views\locations\tmpl\detail.xml AND components\com_jevlocations\views\locations\tmpl\list.xml files:

<field name="modlatest_Mode" type="radio" class="btn-group" default="3" label="COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_LABEL" description="<b>= 0 (default)</b> display closest events for current week and following week only up to maxEvents.<br /><b>= 1</b> same as 0 except some past events for the current week will also be displayed if num of future events is less than maxEvents. <br /><b>= 2</b> display closest events for +days range relative to current day up to maxEvents. <br /><b>= 3</b> same as mode 2 except if there are < maxEvents in the range, then display past events within -days range relative to current day. <br /><b>= 4</b> display closest events for current month up to maxEvents relative to current day.">

should be changed to COM_JEVLOCATIONS_FIELD_DISPLAY_MODE_DESC key in both files.

8. Wrong key usage in menu description in components\com_jevlocations\views\locations\metadata.xml file,
also hard coded strings in this file:

<options var="layout" >
<option value='locations' name="COM_JEVLOCATIONS_LIST_LOCATIONS_TMPL_TITLE" msg="COM_JEVLOCATIONS_LIST_LOCATIONS_TMPL_DESC" />
<option value='locations_blog' name="COM_JEVLOCATIONS_LIST_LOCATIONS_BLOG_TMPL_TITLE" msg="COM_JEVLOCATIONS_LIST_LOCATIONS_BLOG_TMPL_DESC" />
<option value='list' name="COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_TITLE" msg="COM_JEVLOCATIONS_LIST_LOCATIONS_TMPL_DESC" />
<option value='edit' name="COM_JEVLOCATIONS_EDIT_LAYOUT_TMPL_TITLE" msg="COM_JEVLOCATIONS_EDIT_LAYOUT_TMPL_DESC" />
<option value='detail' name="COM_JEVLOCATIONS_DETAIL_LAYOUT_TMPL_TITLE" msg="COM_JEVLOCATIONS_DETAIL_LAYOUT_TMPL_DESC" />
</options>
<options var="task" >
<option value='locations.overview' name="Manage Locations" msg="Manage Locations" />
<option value='locations.locations' name="List of Locations" msg="Locations List" />
<option value='locations.locations' name="List of Locations - Blog layout" msg="Locations List - Blog layout" />
<option value='locations.edit' name="Edit Location" msg="Edit/Create Location" />
<option value='locations.detail' name="Location detail" msg="Show Location" />
</options>

line

<option value='list' name="COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_TITLE" msg="COM_JEVLOCATIONS_LIST_LOCATIONS_TMPL_DESC" />

should be changed to:

<option value='list' name="COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_TITLE" msg="COM_JEVLOCATIONS_MANAGE_LOCATIONS_TMPL_DESC" />


9. Missing key MISSING_IMAGE_FILE in language files, used in administrator\components\com_jevlocations\libraries\helper.php.

10. Missing keys:
COM_JEVLOCATIONS_LOCATIONS_CREATE_DESC
COM_JEVLOCATIONS_LOCATIONS_DELETE_DESC
COM_JEVLOCATIONS_LOCATIONS_EDIT_DESC
in language files (used in locations 'permissions' tab).

11. COM_JEVLOCATIONS_CHECKOVERLAPS in en-GB.com_jevlocations.ini - wrong value its saying something about overlapping events - should it be about overlapping locations?

12. Key TARGET_MENU used in location edit window should be replaced with JEV_TARGET_MENU_FOR_LOCATION_EVENTS_LBL.

13. Wrong key for description in administrator\components\com_jevlocations\config.xml file:

<field
name="lat"
size="20"
type="text"
default=""
label="COM_JEVLOCATIONS_FIELD_LATITUDE_LABEL"
description="COM_JEVLOCATIONS_FIELD_LATITUDE_LABEL"
/>

change to

<field
name="lat"
size="20"
type="text"
default=""
label="COM_JEVLOCATIONS_FIELD_LATITUDE_LABEL"
description="COM_JEVLOCATIONS_FIELD_LATITUDE_DESC"
/>


14. COM_JEVLOCATIONS_FIELD_ADMIN_DESC - string says 'users level' but it should be about 'users group' (?).

15. COM_JEVLOCATIONS_ALLOW_USER_GROUP_BASED_USAGE_DESC - "event creator" should be changed to "location creator" (?).

16. Use of term "common" should have broad explanation (i.e. no description for 'common' field in location edit window).

17. COM_JEVLOCATIONS_COUNTRYCITY_CLICK_TO_EDIT key should be removed it's unnecessary to have it used this way.
8 years ago
·
#6540
0
Votes
Undo
Managed Locations Plugin:

AGAIN... Transifex strings are outdated - there are missing keys i.e. COM_JEVLOCATIONS_FIELD_OPEN_MAP_LINK_IN_NEW_WINDOW_LABEL, COM_JEVLOCATIONS_FIELD_OPEN_MAP_LINK_IN_NEW_WINDOW_DESC at transiflex (available in zip package file).

1. Hard coded names and/or descriptions in
a) manifest administrator\manifests\packages\pkg_jevlocations.xml file:

<name>JEvents Managed Locations Package</name>
(...)
<description>JEvents Managed Locations - Venues, Locations and Maps for JEvents</description>


b) manifest administrator\components\com_jevlocations\manifest.xml file:
	
<name>JEV Locations</name>
(...)
<description>Managed Locations for JEvents</description>


c) manifest plugins\content\jevlocation_embed\jevlocation_embed.xml file:

<name>Content - JEvent Location Embed</name>


d) manifest modules\mod_jevlocations\mod_jevlocations.xml file:

<name>JEvents - Locations</name>


e) manifest plugins\jevents\jevlocations\jevlocations.xml file:

<name>JEvents - Managed Locations</name>
(...)
<description>Assign locations from a managed list of locations to event details.</description>


f) manifest plugins\search\jevlocsearch\jevlocsearch.xml file:

<name>Search - JEvent Locations</name>



2. Hard coded strings in administrator\components\com_jevlocations\views\locations\tmpl\edit.php file:

$result .= '<div id="'.$fieldname.'_loading" class="loading" style="display:none">'.JText::_("Image uploading. One Moment ...") .'</div>';
$result .= '<div id="'.$fieldname.'_loaded" class="loaded" style="display:none">'.JText::_("Upload Complete ...").'</div>';
(...)
$label = JText::_("Image 1");
8 years ago
·
#6539
0
Votes
Undo
JEvents Main (and other misc)

Hard coded strings in modules\mod_jevents_filter\tmpl\default_chosenlayout.php, modules\mod_jevents_filter\tmpl\default_layout.php file:

<?php echo JText::_('ok'); ?>

multiple instances, this string should be either 'search' or 'filter' and translatable of course.

Hard coded and/or missing strings in metadata.xml files (<name> should stay "JEvents" if im not mistaken, also if <state> is deprecated in J2.5+ ignore it):
components\com_jevents\views\admin\metadata.xml:

<state>
<name>JEvents</name>
<description>Manage JEvents Layout</description>
<params>
</params>
</state>

components\com_jevents\views\cat\metadata.xml:

<options var="layout" >
<option value='listevents' name="COM_JEVENTS_LIST_CATEGORY_DEFAULT_TITLE" msg="COM_JEVENTS_LIST_CATEGORY_DEFAULT_DESC" />
</options>
<options var="task" >
<option value='cat.listevents' name="COM_JEVENTS_LIST_CATEGORY_DEFAULT_TITLE" msg="List View of JEvents organised by category" />
</options>
</view>
<state>
<name>JEvents</name>
<description>JEvents List By Category</description>
<params>
</params>
</state>

components\com_jevents\views\day\metadata.xml:

<state>
<name>JEvents</name>
<description>JEvents List By Day</description>
<params>
</params>
</state>

components\com_jevents\views\icalevent\metadata.xml:

<state>
<name>JEvents</name>
<description>Create New Event</description>
<params>
</params>
</state>

components\com_jevents\views\icals\metadata.xml:

<state>
<name>ICal Export</name>
<description>ICal Export Layout</description>
<params >
</params>
</state>

components\com_jevents\views\list\metadata.xml:

<state>
<name>JEvents</name>
<description>JEvents List of Events</description>
<params>
</params>
</state>

components\com_jevents\views\month\metadata.xml:

<state>
<name>JEvents</name>
<description>Monthly Calendar Layout</description>
<params >
</params>
</state>

components\com_jevents\views\range\metadata.xml:

<state>
<name>JEvents</name>
<description>Date Range List of Events</description>
<params >
</params>
</state>

components\com_jevents\views\search\metadata.xml:

<state>
<name>JEvents</name>
<description>Search JEvents</description>
<params>
</params>
</state>

components\com_jevents\views\week\metadata.xml:

<state>
<name>JEvents</name>
<description>JEvents List By Week</description>
<params>
</params>
</state>

components\com_jevents\views\year\metadata.xml:

<state>
<name>JEvents</name>
<description>JEvents List By Year</description>
<params>
<!--
<param name="head" type="textarea" default="" rows="2" cols="50" label="COM_JEVENTS_LIST_HEAD" description="COM_JEVENTS_LIST_HEAD_DESC" />
<param name="row" type="textarea" default="" rows="10" cols="50" label="COM_JEVENTS_LIST_ROW" description="COM_JEVENTS_LIST_ROW_DESC" />
<param name="foot" type="textarea" default="" rows="2" cols="50" label="COM_JEVENTS_LIST_FOOT" description="COM_JEVENTS_LIST_FOOT_DESC" />
//-->
</params>
</state>

components\com_jeventstags\views\tags\metadata.xml (also missing <description> branch):

<options var="layout" >
<option value='tags' name="COM_JEVENTSTAGS_LIST_TAGS_TITLE" msg="COM_JEVENTSTAGS_DEFAULT_TMPL_DESC" />
</options>
<options var="task" >
<option value='tags.tags' name="COM_JEVENTSTAGS_LIST_TAGS_TITLE" msg="Tags List" />
</options>
</view>
<state>
<name>JeventsTags</name>
</state>
There are no replies made for this post yet.

Members Area

Show your support

Unlike many Joomla calendars we do not charge to download JEvents - please show your support for this project by becoming a member of the JEvents Club Club members get access to early releases, exclusive member support forums, and Silver and Gold members can use many exciting JEvents addons

Your membership will ensure that JEvents continues to be the best events calendar for Joomla.